linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] memory: tegra: Make terga20_mc_reset_ops static
@ 2019-04-10 14:04 Yue Haibing
  2019-04-11  9:33 ` Thierry Reding
  0 siblings, 1 reply; 3+ messages in thread
From: Yue Haibing @ 2019-04-10 14:04 UTC (permalink / raw)
  To: thierry.reding, jonathanh, digetx, jroedel
  Cc: linux-kernel, linux-tegra, YueHaibing

From: YueHaibing <yuehaibing@huawei.com>

Fix sparse warning:

drivers/memory/tegra/tegra20.c:277:33: warning:
 symbol 'terga20_mc_reset_ops' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/memory/tegra/tegra20.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/memory/tegra/tegra20.c b/drivers/memory/tegra/tegra20.c
index 7119e53..b786aec 100644
--- a/drivers/memory/tegra/tegra20.c
+++ b/drivers/memory/tegra/tegra20.c
@@ -274,7 +274,7 @@ static int terga20_mc_unblock_dma(struct tegra_mc *mc,
 	return 0;
 }
 
-const struct tegra_mc_reset_ops terga20_mc_reset_ops = {
+static const struct tegra_mc_reset_ops terga20_mc_reset_ops = {
 	.hotreset_assert = terga20_mc_hotreset_assert,
 	.hotreset_deassert = terga20_mc_hotreset_deassert,
 	.block_dma = terga20_mc_block_dma,
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] memory: tegra: Make terga20_mc_reset_ops static
  2019-04-10 14:04 [PATCH -next] memory: tegra: Make terga20_mc_reset_ops static Yue Haibing
@ 2019-04-11  9:33 ` Thierry Reding
  2019-04-11 12:25   ` YueHaibing
  0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2019-04-11  9:33 UTC (permalink / raw)
  To: Yue Haibing; +Cc: jonathanh, digetx, jroedel, linux-kernel, linux-tegra

[-- Attachment #1: Type: text/plain, Size: 740 bytes --]

On Wed, Apr 10, 2019 at 10:04:50PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fix sparse warning:
> 
> drivers/memory/tegra/tegra20.c:277:33: warning:
>  symbol 'terga20_mc_reset_ops' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/memory/tegra/tegra20.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied thanks. I noticed that you use a slightly different name in your
git author settings and your email setup. The only difference seems to
be a space between the first and last name, so you may want to look into
that to avoid having any inconsistencies.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] memory: tegra: Make terga20_mc_reset_ops static
  2019-04-11  9:33 ` Thierry Reding
@ 2019-04-11 12:25   ` YueHaibing
  0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2019-04-11 12:25 UTC (permalink / raw)
  To: Thierry Reding; +Cc: jonathanh, digetx, jroedel, linux-kernel, linux-tegra

On 2019/4/11 17:33, Thierry Reding wrote:
> On Wed, Apr 10, 2019 at 10:04:50PM +0800, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> Fix sparse warning:
>>
>> drivers/memory/tegra/tegra20.c:277:33: warning:
>>  symbol 'terga20_mc_reset_ops' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>  drivers/memory/tegra/tegra20.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied thanks. I noticed that you use a slightly different name in your
> git author settings and your email setup. The only difference seems to
> be a space between the first and last name, so you may want to look into
> that to avoid having any inconsistencies.

Yeah, indeed, I will fix my git config, thanks!

> 
> Thierry
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-11 12:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-10 14:04 [PATCH -next] memory: tegra: Make terga20_mc_reset_ops static Yue Haibing
2019-04-11  9:33 ` Thierry Reding
2019-04-11 12:25   ` YueHaibing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).