From: Nicholas Mc Guire <der.herr@hofr.at>
To: Joe Perches <joe@perches.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
Nicholas Mc Guire <hofrat@opentech.at>,
Ulf Hansson <ulf.hansson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] clk: ux500: add range to usleep_range
Date: Thu, 11 Apr 2019 14:59:18 +0200 [thread overview]
Message-ID: <20190411125918.GB8986@osadl.at> (raw)
In-Reply-To: <c333da513d0e47af3fa91e735ecc6620658f5050.camel@perches.com>
On Thu, Apr 11, 2019 at 04:51:25AM -0700, Joe Perches wrote:
> On Thu, 2019-04-11 at 04:56 +0200, Nicholas Mc Guire wrote:
> > On Wed, Apr 10, 2019 at 03:53:51PM -0700, Stephen Boyd wrote:
> > > Quoting Nicholas Mc Guire (2019-04-06 20:13:24)
> > > > Providing a range for usleep_range() allows the hrtimer subsystem to
> > > > coalesce timers - the delay is runtime configurable so a factor 2
> > > > is taken to provide the range.
> > > >
> > > > Signed-off-by: Nicholas Mc Guire <hofrat@opentech.at>
> > > > ---
> > >
> > > I think this driver is in maintenance mode. I'll wait for Ulf to ack or
> > > review this change before applying.
> > >
> > > > diff --git a/drivers/clk/ux500/clk-sysctrl.c b/drivers/clk/ux500/clk-sysctrl.c
> > > > index 7c0403b..a1fa3fb 100644
> > > > --- a/drivers/clk/ux500/clk-sysctrl.c
> > > > +++ b/drivers/clk/ux500/clk-sysctrl.c
> > > > @@ -42,7 +42,7 @@ static int clk_sysctrl_prepare(struct clk_hw *hw)
> > > > clk->reg_bits[0]);
> > > >
> > > > if (!ret && clk->enable_delay_us)
> > > > - usleep_range(clk->enable_delay_us, clk->enable_delay_us);
> > > > + usleep_range(clk->enable_delay_us, clk->enable_delay_us*2);
> > >
> > > Please add space around that multiply.
> > >
> > I can do that but it does not seem common and also checkpatch
> > did not complain about this - now a simple grep -re "\*10" on the
> > kernel shows that it seems more common not to use spaces around *
> > that to use them.
>
> Not really
>
> $ git grep -P '\*\s*10' | grep -oh -P '\*\s*10' | \
> sort | uniq -c | sort -rn | head
> 11800 * 10
> 1705 *10
> 179 * 10
> 74 * 10
> 67 * 10
> 20 * 10
> 20 * 10
> 14 * 10
> 14 * 10
> 12 * 10
yup - my bad - If you restrict it to code lines - its 1:10
not quite sure how I got the first numbers - sloppy check.
hofrat@debian:~/git/linux-next$ grep -re '.*\*\s*10.*;$' * | grep -oh '\*\s*10' | sort | uniq -c | sort -nr | more
8568 * 10
860 *10
Anyway - is there a reason checkpatch will not flag this ?
thx!
hofrat
>
> > Greping specifically for cases using usleep_range()
> > (not that many) it seems more or less evenly devided between space
> > and no space - so the concern is overlooking that factor 2 ?
> >
> > thx!
> > hofrat
>
next prev parent reply other threads:[~2019-04-11 13:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-07 3:13 [PATCH RFC] clk: ux500: add range to usleep_range Nicholas Mc Guire
2019-04-10 22:53 ` Stephen Boyd
2019-04-11 2:56 ` Nicholas Mc Guire
2019-04-11 11:51 ` Joe Perches
2019-04-11 12:59 ` Nicholas Mc Guire [this message]
2019-04-11 13:12 ` Joe Perches
2019-04-11 13:53 ` Nicholas Mc Guire
2019-04-11 9:36 ` Ulf Hansson
2019-04-11 10:38 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411125918.GB8986@osadl.at \
--to=der.herr@hofr.at \
--cc=hofrat@opentech.at \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).