From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA272C10F0E for ; Fri, 12 Apr 2019 11:48:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FC7221872 for ; Fri, 12 Apr 2019 11:48:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727359AbfDLLsc (ORCPT ); Fri, 12 Apr 2019 07:48:32 -0400 Received: from foss.arm.com ([217.140.101.70]:59036 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726697AbfDLLsc (ORCPT ); Fri, 12 Apr 2019 07:48:32 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6CF8B374; Fri, 12 Apr 2019 04:48:31 -0700 (PDT) Received: from red-moon (unknown [10.1.197.39]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 744C33F718; Fri, 12 Apr 2019 04:48:28 -0700 (PDT) Date: Fri, 12 Apr 2019 12:48:24 +0100 From: Lorenzo Pieralisi To: Kishon Vijay Abraham I Cc: Gustavo Pimentel , Bjorn Helgaas , Rob Herring , Arnd Bergmann , Murali Karicheri , Jingoo Han , Greg Kroah-Hartman , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-kernel@axis.com, Minghuan Lian , Mingkai Hu , Roy Zang , Jesper Nilsson Subject: Re: [PATCH v3 12/26] PCI: keystone: Prevent ARM32 specific code to be compiled for ARM64 Message-ID: <20190412114824.GA8319@red-moon> References: <20190325093947.32633-1-kishon@ti.com> <20190325093947.32633-13-kishon@ti.com> <20190411150332.GC6862@red-moon> <20190412111156.GE8113@red-moon> <9cb169b1-577a-2345-d4b8-ddef4509f80c@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9cb169b1-577a-2345-d4b8-ddef4509f80c@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 12, 2019 at 04:59:36PM +0530, Kishon Vijay Abraham I wrote: > Hi Lorenzo, > > On 12/04/19 4:41 PM, Lorenzo Pieralisi wrote: > > On Fri, Apr 12, 2019 at 02:20:06PM +0530, Kishon Vijay Abraham I wrote: > >> Hi Lorenzo, > >> > >> On 11/04/19 8:33 PM, Lorenzo Pieralisi wrote: > >>> On Mon, Mar 25, 2019 at 03:09:33PM +0530, Kishon Vijay Abraham I wrote: > >>>> hook_fault_code is an ARM32 specific API for hooking into data abort. > >>>> Since pci-keystone.c will be used for AM65X platforms which is an > >>>> ARM64 platform, > >>> > >>> Hi Kishon, > >>> > >>> How is the problem plugged by the fault hook fixed on ARM64 ? > >> > >> At least in AM654 platform, I don't see a bus error when PCIe device > >> is not connected but returns 0xffffffff. So there is no necessary for > >> hook_fault_code in AM654 platform. > > > > That can't have much to do with ARM32<->ARM64, it is rather a platform > > integration issue AFAICS. Russell has a point, this has to be documented > > I can do it for you but I need additional information. > > Right now only ARM32 exports hook_fault_code which was used by K2G (ARM32 > platform) and since AM654 (ARM64 platform) uses the same driver, it'll result > in compilation error. Also AM654 doesn't require hook_fault_code (or something > similar) because it doesn't throw bus error on accessing PCIe address space > when PCI device is not connected). > > Are you looking for some other information? No thanks it was to confirm my understanding, it is really not an ARM<->ARM64 issue, I will try to phrase it in a way that is more explicit. Lorenzo > > Thanks > Kishon > > > > Thanks, > > Lorenzo > > > >> Thanks > >> Kishon > >> > >>> > >>> Thanks, > >>> Lorenzo > >>> > >>>> allow hook_fault_code to be compiled only for ARM32. > >>>> > >>>> Signed-off-by: Kishon Vijay Abraham I > >>>> --- > >>>> drivers/pci/controller/dwc/pci-keystone.c | 4 ++++ > >>>> 1 file changed, 4 insertions(+) > >>>> > >>>> diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c > >>>> index dfe54553d832..93296d434f40 100644 > >>>> --- a/drivers/pci/controller/dwc/pci-keystone.c > >>>> +++ b/drivers/pci/controller/dwc/pci-keystone.c > >>>> @@ -710,6 +710,7 @@ static int ks_pcie_config_legacy_irq(struct keystone_pcie *ks_pcie) > >>>> return ret; > >>>> } > >>>> > >>>> +#ifdef CONFIG_ARM > >>>> /* > >>>> * When a PCI device does not exist during config cycles, keystone host gets a > >>>> * bus error instead of returning 0xffffffff. This handler always returns 0 > >>>> @@ -729,6 +730,7 @@ static int ks_pcie_fault(unsigned long addr, unsigned int fsr, > >>>> > >>>> return 0; > >>>> } > >>>> +#endif > >>>> > >>>> static int __init ks_pcie_init_id(struct keystone_pcie *ks_pcie) > >>>> { > >>>> @@ -778,12 +780,14 @@ static int __init ks_pcie_host_init(struct pcie_port *pp) > >>>> if (ret < 0) > >>>> return ret; > >>>> > >>>> +#ifdef CONFIG_ARM > >>>> /* > >>>> * PCIe access errors that result into OCP errors are caught by ARM as > >>>> * "External aborts" > >>>> */ > >>>> hook_fault_code(17, ks_pcie_fault, SIGBUS, 0, > >>>> "Asynchronous external abort"); > >>>> +#endif > >>>> > >>>> ks_pcie_start_link(pci); > >>>> dw_pcie_wait_for_link(pci); > >>>> -- > >>>> 2.17.1 > >>>>