From: Raul Rangel <rrangel@chromium.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-trace-devel@vger.kernel.org, linux-mmc@vger.kernel.org,
djkurtz@chromium.org, zwisler@chromium.org,
Ludovic Barre <ludovic.barre@st.com>,
Steven Rostedt <rostedt@goodmis.org>,
Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Faiz Abbas <faiz_abbas@ti.com>,
linux-kernel@vger.kernel.org,
Oleksij Rempel <linux@rempel-privat.de>,
Liming Sun <lsun@mellanox.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ingo Molnar <mingo@redhat.com>,
Prabu Thangamuthu <Prabu.T@synopsys.com>,
Chunyan Zhang <chunyan.zhang@unisoc.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v1 0/4] Add tracing for SDHCI register access
Date: Fri, 12 Apr 2019 08:50:12 -0600 [thread overview]
Message-ID: <20190412145012.GA101407@google.com> (raw)
In-Reply-To: <7b77ebcb-b42b-2d14-f5f1-b37e07b88469@intel.com>
On Fri, Apr 12, 2019 at 09:26:44AM +0300, Adrian Hunter wrote:
> On 12/04/19 1:08 AM, Raul E Rangel wrote:
> > I was debugging a SDHC hardware bug and got tired of having to
> > translate the register values by hand. This patch set makes it so all
> > SDHC register read and write operations can be traced and easily read by
> > a human.
>
> While this might be useful for people unfamiliar with SDHCI, I am not sure
> it should be in the upstream kernel.
Can you help me understand your hesitation? Would you prefer removing the
pretty printing? Or would you prefer not having any trace events at all?
The xhci driver has a bunch of pretty print trace events that make it
invaluable when debugging.
https://github.com/torvalds/linux/blob/d7563ca5bfca53398e100eb74345c5d3ef06bf9d/drivers/usb/host/xhci.h#L2160
> Also, it doesn't seem ideal for every
> driver to add its own plumbing for such a feature.
What do you mean by every driver having to add it's own plumbing? Any
driver that uses sdhci_readX or sdhci_writeX get the functionality for
free.
Thanks,
Raul
next prev parent reply other threads:[~2019-04-12 14:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 22:08 [PATCH v1 0/4] Add tracing for SDHCI register access Raul E Rangel
2019-04-11 22:08 ` [PATCH v1 1/4] trace_events: Add trace_print_register to print register fields Raul E Rangel
2019-04-11 22:39 ` Steven Rostedt
2019-04-12 15:30 ` Raul Rangel
2019-04-12 15:42 ` Steven Rostedt
2019-04-11 22:08 ` [PATCH v1 2/4] mmc/sdhci: Rename sdhci.c to sdhci-core.c Raul E Rangel
2019-04-11 22:08 ` [PATCH v1 3/4] mmc/host/sdhci: Add register read and write trace events Raul E Rangel
2019-04-11 22:08 ` [PATCH v1 4/4] mmc/host/sdhci: Make sdhci_read/sdhci_write call trace functions Raul E Rangel
2019-04-12 6:26 ` [PATCH v1 0/4] Add tracing for SDHCI register access Adrian Hunter
2019-04-12 14:50 ` Raul Rangel [this message]
2019-04-18 6:24 ` Adrian Hunter
2019-04-19 18:40 ` Raul Rangel
2019-04-19 19:08 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412145012.GA101407@google.com \
--to=rrangel@chromium.org \
--cc=Jisheng.Zhang@synaptics.com \
--cc=Prabu.T@synopsys.com \
--cc=adrian.hunter@intel.com \
--cc=chunyan.zhang@unisoc.com \
--cc=djkurtz@chromium.org \
--cc=faiz_abbas@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=lsun@mellanox.com \
--cc=ludovic.barre@st.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yamada.masahiro@socionext.com \
--cc=zwisler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).