From: Matthias Kaehlcke <mka@chromium.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH] clk: rockchip: rk3288: Limit use of USB PHY clock to USB
Date: Fri, 12 Apr 2019 11:02:55 -0700 [thread overview]
Message-ID: <20190412180255.GW112750@google.com> (raw)
In-Reply-To: <2029012.W0xZ3ly3fY@diego>
On Fri, Apr 12, 2019 at 11:30:37AM +0200, Heiko Stübner wrote:
> Am Freitag, 12. April 2019, 02:16:57 CEST schrieb Matthias Kaehlcke:
> > Hi Heiko,
> >
> > On Thu, Apr 11, 2019 at 09:03:07PM +0200, Heiko Stübner wrote:
> > > Hi Matthias,
> > >
> > > Am Donnerstag, 11. April 2019, 19:59:17 CEST schrieb Matthias Kaehlcke:
> > > > The USB PHY clock can be configured as (grand) parent of uart0_sclk and
> > > > sclk_gpu. It has been observed that UART0 doesn't work reliably in high
> > > > speed mode with the PHY clock as input when certain USB devices are
> > > > plugged to the USB HOST1 port (see https://crrev.com/c/320543).
> > > >
> > > > Prefix the name of the PHY clock with a '.' in the non-USB muxes to
> > > > effectively remove the clock as input from these muxes.
> > > >
> > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > > > ---
> > > > drivers/clk/rockchip/clk-rk3288.c | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk3288.c
> > > > index 5a67b7869960..677bc5485201 100644
> > > > --- a/drivers/clk/rockchip/clk-rk3288.c
> > > > +++ b/drivers/clk/rockchip/clk-rk3288.c
> > > > @@ -200,8 +200,8 @@ PNAME(mux_aclk_cpu_src_p) = { "cpll_aclk_cpu", "gpll_aclk_cpu" };
> > > > PNAME(mux_pll_src_cpll_gpll_p) = { "cpll", "gpll" };
> > > > PNAME(mux_pll_src_npll_cpll_gpll_p) = { "npll", "cpll", "gpll" };
> > > > PNAME(mux_pll_src_cpll_gpll_npll_p) = { "cpll", "gpll", "npll" };
> > > > -PNAME(mux_pll_src_cpll_gpll_usb480m_p) = { "cpll", "gpll", "usbphy480m_src" };
> > > > -PNAME(mux_pll_src_cpll_gll_usb_npll_p) = { "cpll", "gpll", "usbphy480m_src", "npll" };
> > > > +PNAME(mux_pll_src_cpll_gpll_usb480m_p) = { "cpll", "gpll", ".usbphy480m_src" };
> > > > +PNAME(mux_pll_src_cpll_gll_usb_npll_p) = { "cpll", "gpll", ".usbphy480m_src", "npll" };
> > >
> > > In general I like to have things like the clock-tree described fully
> > > and let the kernel handle correct sourcing ... but:
> > >
> > > As you write this seems like a systemic problem when just connecting
> > > random peripherals can create unstable clock source frequencies,
> > > so I tend to agree here ... but:
> > >
> > > Can we please find a more "talking" name for this ... because as with the
> > > above someone will find the "." and submit a fix for it ;-) .
> > >
> > > So just name it "unstable_dummy" or so?
> >
> > I looked for some common pattern, but couldn't find one. I liked the
> > '.' since it leaves the name of the clock mostly intact, just hiding
> > it (similar to a leading '.' in a Linux file system). But I agree that
> > it might not be expressive enough. I still like the idea to keep the
> > clock name around for reference, maybe we could name it
> > "unstable:usbphy480m_src" or similar. If you don't object I'll send a
> > patch with this some time tomorrow.
>
> I've just adapted the patch to use the new parent-name you suggested
> and applied it for 5.2 So no need to resend :-) .
Pefect, thanks!
I don't see the patch in the git.kernel.org repo (nor
https://lore.kernel.org/patchwork/patch/1060781/), looks like the push
is still pending.
Cheers
Matthias
next prev parent reply other threads:[~2019-04-12 18:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 17:59 [PATCH] clk: rockchip: rk3288: Limit use of USB PHY clock to USB Matthias Kaehlcke
2019-04-11 19:03 ` Heiko Stübner
2019-04-12 0:16 ` Matthias Kaehlcke
2019-04-12 9:30 ` Heiko Stübner
2019-04-12 18:02 ` Matthias Kaehlcke [this message]
2019-04-12 18:55 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412180255.GW112750@google.com \
--to=mka@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).