linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
	Waiman Long <longman@redhat.com>, shenghui <shhuiw@foxmail.com>
Subject: Re: [PATCH] locking/lockdep: Make lockdep_register_key() ignore 'debug_locks'
Date: Sat, 13 Apr 2019 10:29:55 +0200	[thread overview]
Message-ID: <20190413082955.GA112331@gmail.com> (raw)
In-Reply-To: <1555083162.161891.83.camel@acm.org>


* Bart Van Assche <bvanassche@acm.org> wrote:

> On Fri, 2019-04-12 at 07:47 +0200, Ingo Molnar wrote:
> > So why don't we add a debug_locks test to lockdep_unregister_key() 
> > instead? The general principle to bring lockdep to a screeching halt when 
> > bugs are detected, ASAP.
> 
> Hi Ingo,
> 
> Since this issue was introduced by patch "locking/lockdep: Zap lock classes
> even with lock debugging disabled" and since that patch is in the tip tree
> but not yet upstream: do you prefer that I post a version 3 of that patch or
> do you rather prefer that I post a follow-up patch?

The crash fix is now upstream, mind sending a followup patch for the 
warning fix?

Thanks,

	Ingo

      reply	other threads:[~2019-04-13  8:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 17:26 [PATCH] locking/lockdep: Make lockdep_register_key() ignore 'debug_locks' Bart Van Assche
2019-04-12  5:47 ` Ingo Molnar
2019-04-12 15:32   ` Bart Van Assche
2019-04-13  8:29     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190413082955.GA112331@gmail.com \
    --to=mingo@kernel.org \
    --cc=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=shhuiw@foxmail.com \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).