From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED215C10F11 for ; Sat, 13 Apr 2019 11:08:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEF8D20850 for ; Sat, 13 Apr 2019 11:08:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="OcnT6SPE"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="FP6AhaLg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727144AbfDMLIF (ORCPT ); Sat, 13 Apr 2019 07:08:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38174 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726874AbfDMLIE (ORCPT ); Sat, 13 Apr 2019 07:08:04 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id CC98C60779; Sat, 13 Apr 2019 11:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1555153683; bh=7uED1utPkXKqPOGLrthcKCGcWxNce24mj7cNul9UnaY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=OcnT6SPE5OSa5W5mXX8T3kQWLxehwE8fVuJ4VFKYTVHxM1v1DGpVcGcdDD0KL3Or2 Fncb54+KM364uAeitOsREiypntDVTQn/z6QXZkxMQEruPDV4b+wfgMnZEdms19chQ1 gyhtkHYAiWiV+nkjgxDK74girNW65pj8ZLzUd/Qo= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1C90E61577; Sat, 13 Apr 2019 11:07:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1555153683; bh=7uED1utPkXKqPOGLrthcKCGcWxNce24mj7cNul9UnaY=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=FP6AhaLgLbVeEO8WFEahWCO9cB6fnxia7BZgCC8jW15fbNrVD0OpUQYLrQvmwJ8F5 A8E+fm8M7fRldP5pRTYxX5SDJTls4DSURRDY0TlfVb2hf4gr9ScBVnyRIUJgj+US0Q 7Va8BxWrQHOMMYez9BP4om6wJwwczMHDYAwJg/QM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1C90E61577 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH][V2] brcmfmac: fix leak of mypkt on error return path From: Kalle Valo In-Reply-To: <20190409114333.24342-1-colin.king@canonical.com> References: <20190409114333.24342-1-colin.king@canonical.com> To: Colin King Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , "David S . Miller" , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190413110803.CC98C60779@smtp.codeaurora.org> Date: Sat, 13 Apr 2019 11:08:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King wrote: > From: Colin Ian King > > Currently if the call to brcmf_sdiod_set_backplane_window fails then > error return path leaks mypkt. Fix this by returning by a new > error path labelled 'out' that calls brcmu_pkt_buf_free_skb to free > mypkt. Also remove redundant check on err before calling > brcmf_sdiod_skbuff_write. > > Addresses-Coverity: ("Resource Leak") > Fixes: a7c3aa1509e2 ("brcmfmac: Remove brcmf_sdiod_addrprep()") > Signed-off-by: Colin Ian King > Reviewed-by: Mukesh Ojha Patch applied to wireless-drivers-next.git, thanks. a927e8d8ab57 brcmfmac: fix leak of mypkt on error return path -- https://patchwork.kernel.org/patch/10891135/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches