From: Vinod Koul <vkoul@kernel.org>
To: Jan Kotas <jank@cadence.com>
Cc: sanyog.r.kale@intel.com, pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soundwire: cdns: Fix compilation error on arm64
Date: Sun, 14 Apr 2019 15:14:08 +0530 [thread overview]
Message-ID: <20190414094408.GF28103@vkoul-mobl> (raw)
In-Reply-To: <20190404081221.341-1-jank@cadence.com>
On 04-04-19, 09:12, Jan Kotas wrote:
> On arm64 the cadence_master.c file doesn't compile.
>
> readl and writel are undefined.
> This patch fixes that by including io.h.
And I cant verify that without hacking kconfig to force compile the lib.
>
> Signed-off-by: Jan Kotas <jank@cadence.com>
> ---
> drivers/soundwire/cadence_master.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
> index cb6a331f4..0b5bcc209 100644
> --- a/drivers/soundwire/cadence_master.c
> +++ b/drivers/soundwire/cadence_master.c
> @@ -9,6 +9,7 @@
> #include <linux/delay.h>
> #include <linux/device.h>
> #include <linux/interrupt.h>
> +#include <linux/io.h>
Why not add asm/io.h which is the header that actually defines
readl/writel?
> #include <linux/module.h>
> #include <linux/mod_devicetable.h>
> #include <linux/soundwire/sdw_registers.h>
> --
> 2.15.0
--
~Vinod
next prev parent reply other threads:[~2019-04-14 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 8:12 [PATCH] soundwire: cdns: Fix compilation error on arm64 Jan Kotas
2019-04-04 8:52 ` Mukesh Ojha
2019-04-14 9:44 ` Vinod Koul [this message]
2019-04-15 12:41 ` [alsa-devel] " Pierre-Louis Bossart
2019-04-16 8:43 ` Jan Kotas
2019-05-09 7:00 ` Jan Kotas
2019-05-27 5:07 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190414094408.GF28103@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).