From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1283EC10F13 for ; Sun, 14 Apr 2019 19:13:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0E4B20818 for ; Sun, 14 Apr 2019 19:13:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="daDh6G31" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726810AbfDNTNV (ORCPT ); Sun, 14 Apr 2019 15:13:21 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60906 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbfDNTNU (ORCPT ); Sun, 14 Apr 2019 15:13:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=83Zt+sF62/UwECkI8XPRC/QymuI41c0gfQ0VRV+3PPM=; b=daDh6G316ZcEltEQncp5CvYPl3 bIrV+UFwTtdS/DeVHS1duE3Qfx2f7uMStXiXG9E9uoyXkUiugeKb1KthJ4RqZb2gsNnua5pZ5cnDC oFbe2mp1MWjsXcZofPJfkYdioZKBNbjEjmKts3q04gCYd/lCErGcxZdZEF7TRwl174/8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hFkZ4-0004KM-1E; Sun, 14 Apr 2019 21:13:18 +0200 Date: Sun, 14 Apr 2019 21:13:18 +0200 From: Andrew Lunn To: Vladimir Oltean Cc: Florian Fainelli , vivien.didelot@gmail.com, davem@davemloft.net, netdev , linux-kernel@vger.kernel.org, Georg Waibel Subject: Re: [PATCH v3 net-next 18/24] net: dsa: sja1105: Add support for traffic through standalone ports Message-ID: <20190414191318.GE10323@lunn.ch> References: <20190413012822.30931-1-olteanv@gmail.com> <20190413012822.30931-19-olteanv@gmail.com> <20190413163754.GG17901@lunn.ch> <20190414161757.GB10323@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 14, 2019 at 09:53:42PM +0300, Vladimir Oltean wrote: > On Sun, 14 Apr 2019 at 19:18, Andrew Lunn wrote: > > > > > > > > > + return dsa_8021q_xmit(skb, netdev, ETH_P_EDSA, > > > > > > > + ((pcp << VLAN_PRIO_SHIFT) | tx_vid)); > > > > > > > > > > > > Please don't reuse ETH_P_EDSA. Define an ETH_P_SJA1105. > > > > > > > > > > > > I'm receiving contradictory advice on this. Why should I define a new > > > ethertype, and if I do, what scope should the definition have (local > > > to the driver and the tagger, local to DSA, UAPI)? > > > > ETH_P_EDSA has a well defined meaning. It is a true global EtherType, > > and means a Marvell EtherType DSA header follows. > > > > You are polluting this meaning of ETH_P_EDSA. Would you put ETH_P_IP > > or ETH_P_8021AD here? > > > > Andrew > > You are putting an equality sign here between things that are not quite equal. > The MEDSA EtherType is used for the same purpose as what I'm using it for. I don't think it is. tcpdump will match on this EtherType and decode what follows as an EDSA header, just in the same way it matches a ETH_P_IP and decodes what comes next as an IP packet. I also have wireshark patches, which i never submitted, which do the same. Please run tcpdump on the master interface with your test system and see what it does. Andrew