From: Peter Zijlstra <peterz@infradead.org>
To: Bandan Das <bsd@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@redhat.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] perf/x86: descriptive failure messages for PMU init
Date: Mon, 15 Apr 2019 14:04:44 +0200 [thread overview]
Message-ID: <20190415120444.GN11158@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <jpg5zrjavmq.fsf@linux.bootlegged.copy>
On Fri, Apr 12, 2019 at 03:09:17PM -0400, Bandan Das wrote:
>
> There's a default warning message that gets printed, however,
> there are various failure conditions:
> - a msr read can fail
> - a msr write can fail
> - a msr has an unexpected value
> - all msrs have unexpected values (disable PMU)
>
> Also, commit commit 005bd0077a79 ("perf/x86: Modify error message in
> virtualized environment") completely removed printing the msr in
> question but these messages could be helpful for debugging vPMUs as
> well. Add them back and change them to pr_debugs, this keeps the
> behavior the same for baremetal.
>
> Lastly, use %llx to silence checkpatch
Yuck... if you're debugging a hypervisor, you can bloody well run your
own kernel with additional print slattered around.
The whole make an exception for virt bullshit was already pushing it,
this is just insane.
> @@ -266,12 +282,30 @@ static bool check_hw_exists(void)
> return true;
>
> msr_fail:
> - if (boot_cpu_has(X86_FEATURE_HYPERVISOR)) {
> + if (virt)
> pr_cont("PMU not available due to virtualization, using software events only.\n");
> - } else {
> - pr_cont("Broken PMU hardware detected, using software events only.\n");
> - pr_err("Failed to access perfctr msr (MSR %x is %Lx)\n",
> - reg, val_new);
> + switch (status) {
> + case READ_FAIL:
> + if (virt)
> + pr_debug("Failed to read perfctr msr (MSR %x)\n", reg);
> + else
> + pr_err("Failed to read perfctr msr (MSR %x)\n", reg);
> + break;
> + case WRITE_FAIL:
> + if (virt)
> + pr_debug("Failed to write perfctr msr (MSR %x, wrote: %llx, read: %llx)\n",
> + reg, val, val_new);
> + else
> + pr_err("Failed to write perfctr msr (MSR %x, wrote: %llx, read: %llx)\n",
> + reg, val, val_new);
> + break;
> + case PMU_FAIL:
> + /* fall through for default message */
> + default:
> + if (virt)
> + pr_debug("Broken PMU hardware detected, using software events only.\n");
> + else
> + pr_cont("Broken PMU hardware detected, using software events only.\n");
> }
next prev parent reply other threads:[~2019-04-15 12:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 19:09 [PATCH] perf/x86: descriptive failure messages for PMU init Bandan Das
2019-04-15 9:48 ` Jiri Olsa
2019-04-15 12:04 ` Peter Zijlstra [this message]
2019-04-15 12:42 ` Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415120444.GN11158@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=bsd@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).