From: Bharath Vedartham <linux.bhar@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: keescook@chromium.org, arnd@arndb.de, akpm@linux-foundation.org,
reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/reiserfs/journal.c: Make remove_journal_hash static
Date: Mon, 15 Apr 2019 20:36:39 +0530 [thread overview]
Message-ID: <20190415150639.GA32075@bharath12345-Inspiron-5559> (raw)
In-Reply-To: <20190415094739.GA13684@quack2.suse.cz>
On Mon, Apr 15, 2019 at 11:47:39AM +0200, Jan Kara wrote:
> On Sun 14-04-19 16:54:38, Bharath Vedartham wrote:
> > This fixes the -WDecl sparse warning in journal.c. Function was declared
> > as static void but the definition was void.
> >
> > Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
>
> Thanks! I've added your patch into my tree.
>
Thanks Jan!
> Honza
>
> > ---
> > fs/reiserfs/journal.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> > index 8a76f9d..36346dc 100644
> > --- a/fs/reiserfs/journal.c
> > +++ b/fs/reiserfs/journal.c
> > @@ -1844,7 +1844,7 @@ static int flush_used_journal_lists(struct super_block *s,
> > * removes any nodes in table with name block and dev as bh.
> > * only touchs the hnext and hprev pointers.
> > */
> > -void remove_journal_hash(struct super_block *sb,
> > +static void remove_journal_hash(struct super_block *sb,
> > struct reiserfs_journal_cnode **table,
> > struct reiserfs_journal_list *jl,
> > unsigned long block, int remove_freed)
> > --
> > 2.7.4
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
prev parent reply other threads:[~2019-04-15 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 11:24 [PATCH] fs/reiserfs/journal.c: Make remove_journal_hash static Bharath Vedartham
2019-04-15 9:47 ` Jan Kara
2019-04-15 15:06 ` Bharath Vedartham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415150639.GA32075@bharath12345-Inspiron-5559 \
--to=linux.bhar@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=jack@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).