From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92546C10F0E for ; Mon, 15 Apr 2019 15:14:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65F4B20818 for ; Mon, 15 Apr 2019 15:14:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727611AbfDOPOz (ORCPT ); Mon, 15 Apr 2019 11:14:55 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:53005 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726147AbfDOPOz (ORCPT ); Mon, 15 Apr 2019 11:14:55 -0400 X-Originating-IP: 109.212.207.226 Received: from localhost (alyon-652-1-176-226.w109-212.abo.wanadoo.fr [109.212.207.226]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id AC1A6FF80F; Mon, 15 Apr 2019 15:14:51 +0000 (UTC) Date: Mon, 15 Apr 2019 17:14:50 +0200 From: Alexandre Belloni To: Masahiro Yamada Cc: arm@kernel.org, Olof Johansson , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ludovic Desroches , Nicolas Ferre , Russell King Subject: Re: [PATCH 2/3] ARM: at91: move platform-specific asm-offset.h to arch/arm/mach-at91 Message-ID: <20190415151450.GG3578@piout.net> References: <20190408075427.6052-1-yamada.masahiro@socionext.com> <20190408075427.6052-2-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190408075427.6052-2-yamada.masahiro@socionext.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/04/2019 16:54:26+0900, Masahiro Yamada wrote: > is only generated and included > by arch/arm/mach-at91/, so it does not need to reside in the > globally visible include/generated/. > > I moved and renamed it to arch/arm/mach-at91/pm_data-offsets.h > since the prefix 'at91_' is just redundant in mach-at91/. > > Signed-off-by: Masahiro Yamada Acked-by: Alexandre Belloni > --- > > Can this be applied to ARM-SOC tree in a series? > (with Ack from the platform sub-maintainer.) > > at91_pm_data-offsets.h header does not need to reside in > include/generated/, but you may ask > "Why must it get out of include/generated/?" > > My main motivation is to avoid a race condition in the currently > proposed patch: > > https://lore.kernel.org/patchwork/patch/1052763/ > > This patch tries to embed some build artifacts into the kernel. > > If arch/arm/mach-at91/ and kernel/ are built at the same time, > it may embed a truncated file. > > > arch/arm/mach-at91/.gitignore | 1 + > arch/arm/mach-at91/Makefile | 5 +++-- > arch/arm/mach-at91/pm_suspend.S | 2 +- > 3 files changed, 5 insertions(+), 3 deletions(-) > create mode 100644 arch/arm/mach-at91/.gitignore > > diff --git a/arch/arm/mach-at91/.gitignore b/arch/arm/mach-at91/.gitignore > new file mode 100644 > index 000000000000..2ecd6f51c8a9 > --- /dev/null > +++ b/arch/arm/mach-at91/.gitignore > @@ -0,0 +1 @@ > +pm_data-offsets.h > diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile > index 31b61f0e1c07..de64301dcff2 100644 > --- a/arch/arm/mach-at91/Makefile > +++ b/arch/arm/mach-at91/Makefile > @@ -19,9 +19,10 @@ ifeq ($(CONFIG_PM_DEBUG),y) > CFLAGS_pm.o += -DDEBUG > endif > > -include/generated/at91_pm_data-offsets.h: arch/arm/mach-at91/pm_data-offsets.s FORCE > +$(obj)/pm_data-offsets.h: $(obj)/pm_data-offsets.s FORCE > $(call filechk,offsets,__PM_DATA_OFFSETS_H__) > > -arch/arm/mach-at91/pm_suspend.o: include/generated/at91_pm_data-offsets.h > +$(obj)/pm_suspend.o: $(obj)/pm_data-offsets.h > > targets += pm_data-offsets.s > +clean-files += pm_data-offsets.h > diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S > index bfe1c4d06901..a31c1b20f3fa 100644 > --- a/arch/arm/mach-at91/pm_suspend.S > +++ b/arch/arm/mach-at91/pm_suspend.S > @@ -14,7 +14,7 @@ > #include > #include > #include "pm.h" > -#include "generated/at91_pm_data-offsets.h" > +#include "pm_data-offsets.h" > > #define SRAMC_SELF_FRESH_ACTIVE 0x01 > #define SRAMC_SELF_FRESH_EXIT 0x00 > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com