From: Greg KH <gregkh@linuxfoundation.org>
To: zhuyan <zhuyan34@huawei.com>
Cc: anton@enomsg.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb:host: fix divide-by-zero in function fhci_queue_urb
Date: Tue, 16 Apr 2019 11:45:45 +0200 [thread overview]
Message-ID: <20190416094545.GA896@kroah.com> (raw)
In-Reply-To: <1554820632-13782-1-git-send-email-zhuyan34@huawei.com>
On Tue, Apr 09, 2019 at 10:37:12PM +0800, zhuyan wrote:
> In function fhci_queue_urb, the divisor of expression
> (urb->transfer_buffer_length % usb_maxpacket(urb->dev, urb->pipe,
> usb_pipeout(urb->pipe))) may be zero.
How can you hit that?
> When it is zero, unexpected results may occur, so it is necessary to
> ensure that the divisor is not zero.
>
> Signed-off-by: zhuyan <zhuyan34@huawei.com>
I need a "Full" name here, not just a single name. Whatever you use to
sign documents is good.
thanks,
greg k-h
next prev parent reply other threads:[~2019-04-16 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 14:37 [PATCH] usb:host: fix divide-by-zero in function fhci_queue_urb zhuyan
2019-04-16 9:45 ` Greg KH [this message]
2019-04-16 14:48 zhuyan (M)
2019-04-16 15:07 ` Alan Stern
2019-04-17 7:09 zhuyan (M)
2019-04-17 13:45 ` Alan Stern
2019-04-17 15:33 zhuyan (M)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416094545.GA896@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anton@enomsg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=zhuyan34@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).