From: "Theodore Ts'o" <tytso@mit.edu>
To: Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Laura Abbott <labbott@redhat.com>,
Daniel Micay <danielmicay@gmail.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Tobin C. Harding" <me@tobin.cc>, Arnd Bergmann <arnd@arndb.de>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] random: Move rand_initialize() earlier
Date: Tue, 16 Apr 2019 12:09:48 -0400 [thread overview]
Message-ID: <20190416160948.GE3004@mit.edu> (raw)
In-Reply-To: <CAGXu5jJwLSRM4y-SK2d600ha2-ui8ibaGQa_qws8kmP=Yu1+oA@mail.gmail.com>
On Mon, Apr 15, 2019 at 10:46:34PM -0500, Kees Cook wrote:
> On Fri, Oct 12, 2018 at 9:45 AM Kees Cook <keescook@chromium.org> wrote:
> >
> > On Fri, Oct 12, 2018 at 7:29 AM, Theodore Y. Ts'o <tytso@mit.edu> wrote:
> > > On Thu, Oct 11, 2018 at 03:54:21PM -0700, Kees Cook wrote:
> > >> Right now rand_initialize() is run as an early_initcall(), but it only
> > >> depends on timekeeping_init() (for mixing ktime_get_real() into the
> > >> pools). However, the call to boot_init_stack_canary() for stack canary
> > >> initialization runs earlier, which triggers a warning at boot:
> > >>
> > >> random: get_random_bytes called from start_kernel+0x357/0x548 with crng_init=0
> > >>
> > >> Instead, this moves rand_initialize() to after timekeeping_init(), and moves
> > >> canary initialization here as well.
> > >>
> > >> Note that this warning may still remain for machines that do not have
> > >> UEFI RNG support (which initializes the RNG pools durting setup_arch()),
> > >> or for x86 machines without RDRAND (or booting without "random.trust=on"
> > >> or CONFIG_RANDOM_TRUST_CPU=y).
> > >>
> > >> Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Hi Ted! Did this get lost? This has come up again, and I don't see it
> having landed anywhere yet. Can you take this?
Yeah, sorry, it got lost; my bad. I'll take it and push it out at the
next merge window.
- Ted
next prev parent reply other threads:[~2019-04-16 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 22:54 [PATCH] random: Move rand_initialize() earlier Kees Cook
2018-10-12 8:42 ` Arnd Bergmann
2018-10-12 14:43 ` Theodore Y. Ts'o
2018-10-12 14:29 ` Theodore Y. Ts'o
2018-10-12 14:45 ` Kees Cook
2019-04-16 3:46 ` Kees Cook
2019-04-16 16:09 ` Theodore Ts'o [this message]
2019-04-16 23:00 ` Kees Cook
2019-04-23 22:20 ` Kees Cook
2019-04-24 22:10 ` Theodore Ts'o
2019-04-24 23:14 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416160948.GE3004@mit.edu \
--to=tytso@mit.edu \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=danielmicay@gmail.com \
--cc=keescook@chromium.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).