From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=FAKE_REPLY_C, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D697C282DD for ; Wed, 17 Apr 2019 12:23:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6EC822173C for ; Wed, 17 Apr 2019 12:23:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732127AbfDQMX6 (ORCPT ); Wed, 17 Apr 2019 08:23:58 -0400 Received: from mx2.suse.de ([195.135.220.15]:48918 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731960AbfDQMX5 (ORCPT ); Wed, 17 Apr 2019 08:23:57 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id F3B44AD72; Wed, 17 Apr 2019 12:23:55 +0000 (UTC) Date: Wed, 17 Apr 2019 14:23:50 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Andrew Morton , Cyrill Gorcunov Cc: Sergey Senozhatsky , kbuild-all@01.org, LKML , Michal Hocko , Randy Dunlap , Andrey Vagin , Andrew Morton , Pavel Emelyanov , Michael Kerrisk , Yang Shi , kbuild test robot Subject: Re: [PATCH] prctl: Don't compile some of prctl functions when CRUI Message-ID: <20190417122349.GA15498@blackbody.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180420140044.478b4c88d3cf238bd440f2a7@linux-foundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi. I see this discussion somewhat faded away since the previous year. There was rework [1] that reduced (ab)use of mmap_sem in prctl functions. Actually, there still remains the down_write() in prctl_set_mm. I considered at least replacing it with the mm_struct.arg_lock + down_read() but then I learnt about this thread intending to remove that part completely. I wouldn't oppose if CRIU is the sole (aware) user. Ad the bot build issue, I could build the kernel both with CONFIG_CHECKPOINT_RESTORE and without CONFIG_CHECKPOINT_RESTORE just fine after applying the two proposed patches. What is the current state? Perhaps, this change should be CCed to linux-api@vger.kernel.org(?). Thanks, Michal [1] https://lore.kernel.org/lkml/1523730291-109696-1-git-send-email-yang.shi@linux.alibaba.com/T/