From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AB2AC282DC for ; Wed, 17 Apr 2019 16:43:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AE0220835 for ; Wed, 17 Apr 2019 16:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555519398; bh=Y92TYr3rmhsAk5BX4v6HSxFN8z0Bs9i9xaFmJ00iP3E=; h=From:To:Cc:Subject:In-Reply-To:Date:List-ID:From; b=1mx7zswybJIbRSgssJb/e3xX5w1kkpJSASWsVG7/3HHUhYbt9py90EaZU5ae9X9rP HSzYeKG9RwrwMzvKB/kvgJku1K2FHq4eEDoG7fcuM8c6c6AJIqtMPZ7bqfRwAndKtK vsielymXGoHrLyRCuar83haGo1HrZ/Xh6/d1x55U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732930AbfDQQm1 (ORCPT ); Wed, 17 Apr 2019 12:42:27 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:37264 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732476AbfDQQmZ (ORCPT ); Wed, 17 Apr 2019 12:42:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=NloOXLLDC6qypCcKIDAAZh9s94C8AYM8PEzGnnKiNUc=; b=ByyTqp7KABv2 fG8zaQhSFX6N0Y2u0G1IwreLX6CoG6FKsjWMc3zIUtc60URosJKqadZr4+xp/50fWrFXvJS0FDviX ZTx+xm7ivwtm/5d2sNHvPUuJ3qCxCVuSJBNEPmbKD5aZTSJ2VaUBCoou2r0vvHkfi6SaVhRrRra2v SzYJA=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1hGndY-000151-Mc; Wed, 17 Apr 2019 16:42:16 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 39C531128FCB; Wed, 17 Apr 2019 17:42:16 +0100 (BST) From: Mark Brown To: Wei Yongjun Cc: Alexandre Torgue , kernel-janitors@vger.kernel.org, Liam Girdwood , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Mark Brown , Maxime Coquelin , Pascal PAILLET-LME Subject: Applied "regulator: stm32-pwr: Fix return value check in stm32_pwr_regulator_probe()" to the regulator tree In-Reply-To: <20190417023059.162828-1-weiyongjun1@huawei.com> X-Patchwork-Hint: ignore Message-Id: <20190417164216.39C531128FCB@debutante.sirena.org.uk> Date: Wed, 17 Apr 2019 17:42:16 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch regulator: stm32-pwr: Fix return value check in stm32_pwr_regulator_probe() has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From dc62f951a6a8490bcccc7b6de36cd85bd57be740 Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Wed, 17 Apr 2019 02:30:59 +0000 Subject: [PATCH] regulator: stm32-pwr: Fix return value check in stm32_pwr_regulator_probe() In case of error, the function of_iomap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 6cdae8173f67 ("regulator: Add support for stm32 power regulators") Signed-off-by: Wei Yongjun Signed-off-by: Mark Brown --- drivers/regulator/stm32-pwr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/stm32-pwr.c b/drivers/regulator/stm32-pwr.c index 222d593d76a2..7b39a41530d4 100644 --- a/drivers/regulator/stm32-pwr.c +++ b/drivers/regulator/stm32-pwr.c @@ -140,9 +140,9 @@ static int stm32_pwr_regulator_probe(struct platform_device *pdev) int i, ret = 0; base = of_iomap(np, 0); - if (IS_ERR(base)) { + if (!base) { dev_err(&pdev->dev, "Unable to map IO memory\n"); - return PTR_ERR(base); + return -ENOMEM; } config.dev = &pdev->dev; -- 2.20.1