From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Joao Pinto <Joao.Pinto@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>
Subject: Re: [PATCH net-next 0/2] net: stmmac: Enable Flow Control
Date: Wed, 17 Apr 2019 21:01:01 +0300 [thread overview]
Message-ID: <20190417180101.GA7350@darkstar.musicnaut.iki.fi> (raw)
In-Reply-To: <cover.1555486210.git.joabreu@synopsys.com>
Hi,
On Wed, Apr 17, 2019 at 09:33:03AM +0200, Jose Abreu wrote:
> I don't know of any specific reason why Flow Control is off by default but
> do let me know if there is any.
It seems dwmac1000 assumes 4K FIFO size when configuring threshold
values. This could be non-optimal for 8K/16K FIFOs, but that can be
fixed later on with incremental patches.
A.
prev parent reply other threads:[~2019-04-17 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 7:33 [PATCH net-next 0/2] net: stmmac: Enable Flow Control Jose Abreu
2019-04-17 7:33 ` [PATCH net-next 1/2] net: stmmac: dwxgmac: Finish the Flow Control implementation Jose Abreu
2019-04-17 7:33 ` [PATCH net-next 2/2] net: stmmac: Set Flow Control to automatic mode in the driver Jose Abreu
2019-04-17 17:14 ` [PATCH net-next 0/2] net: stmmac: Enable Flow Control David Miller
2019-04-17 18:01 ` Aaro Koskinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417180101.GA7350@darkstar.musicnaut.iki.fi \
--to=aaro.koskinen@iki.fi \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).