From: Peter Zijlstra <peterz@infradead.org>
To: Kairui Song <kasong@redhat.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, Dave Young <dyoung@redhat.com>
Subject: Re: [RFC PATCH v2] perf/x86: make perf callchain work without CONFIG_FRAME_POINTER
Date: Thu, 18 Apr 2019 09:54:12 +0200 [thread overview]
Message-ID: <20190418075412.GO12232@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CACPcB9cuvNt-+gw8_LzqDLZ-nZ+G_zLcSv6nftNONrYxVRx=wg@mail.gmail.com>
On Wed, Apr 17, 2019 at 10:44:33PM +0800, Kairui Song wrote:
> Despite it's hacky, it seems not necessary to dump every register. And
> is there a straight way to get caller's regs in the trace point? It
> seems more trouble some. Or if we just use the regs inside the
> tracepoint, but it would need even more workaround (eg. unwind one
> frame before do anything).
Sure, and the current code doesn't fill out every reg either, but given
SAMPLE_REGS_INTR I think we should at least clear the entire regs before
passing it on, or otherwise make sure SAMPLE_REGS_INTR isn't allowed on
these events.
prev parent reply other threads:[~2019-04-18 7:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 16:59 [RFC PATCH v2] perf/x86: make perf callchain work without CONFIG_FRAME_POINTER Kairui Song
2019-04-15 12:38 ` Jiri Olsa
2019-04-15 15:36 ` Peter Zijlstra
2019-04-15 16:58 ` Josh Poimboeuf
2019-04-16 11:30 ` Kairui Song
2019-04-16 16:16 ` Alexei Starovoitov
2019-04-16 17:39 ` Kairui Song
2019-04-16 17:45 ` Peter Zijlstra
2019-04-17 14:41 ` Kairui Song
2019-04-16 20:15 ` Josh Poimboeuf
2019-04-17 7:07 ` Peter Zijlstra
2019-04-18 2:15 ` Josh Poimboeuf
2019-04-17 14:44 ` Kairui Song
2019-04-18 7:54 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418075412.GO12232@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=jolsa@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=kasong@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).