From: Quentin Perret <quentin.perret@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: edubezval@gmail.com, rui.zhang@intel.com, javi.merino@kernel.org,
amit.kachhap@gmail.com, rjw@rjwysocki.net, will.deacon@arm.com,
catalin.marinas@arm.com, daniel.lezcano@linaro.org,
dietmar.eggemann@arm.com, ionela.voinescu@arm.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, mka@chromium.org
Subject: Re: [PATCH v2 3/3] thermal: cpu_cooling: Migrate to using the EM framework
Date: Thu, 18 Apr 2019 09:04:32 +0100 [thread overview]
Message-ID: <20190418080429.pn4r6lnftlfsf4c4@queper01-lin> (raw)
In-Reply-To: <20190418035323.onyfxo4kprwqz2wl@vireshk-mac-ubuntu>
On Thursday 18 Apr 2019 at 09:23:23 (+0530), Viresh Kumar wrote:
> On 17-04-19, 10:43, Quentin Perret wrote:
> > static struct thermal_cooling_device *
> > __cpufreq_cooling_register(struct device_node *np,
> > - struct cpufreq_policy *policy, u32 capacitance)
> > + struct cpufreq_policy *policy,
> > + struct em_perf_domain *em)
> > {
>
> > + if (em_is_sane(cpufreq_cdev, em)) {
> > + cpufreq_cdev->em = em;
> > cooling_ops = &cpufreq_power_cooling_ops;
> > - } else {
> > + } else if (policy->freq_table_sorted != CPUFREQ_TABLE_UNSORTED) {
> > cooling_ops = &cpufreq_cooling_ops;
> > + } else {
> > + WARN(1, "cpu_cooling: no valid frequency table found\n");
>
> Well the frequency table is valid, isn't it ?
True ...
> Maybe something like: "cpu_cooling doesn't support unsorted frequency tables" ?
Right, otherwise I guess that could be confused with the check on
cpu_table_count_valid_entries() above. And while I'm thinking about it
perhaps WARN is a bit too much here ? We can handle the error safely so
pr_err() should be enough ?
Thanks,
Quentin
next prev parent reply other threads:[~2019-04-18 8:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 9:42 [PATCH v2 0/3] Make IPA use PM_EM Quentin Perret
2019-04-17 9:42 ` [PATCH v2 1/3] arm64: defconfig: Enable CONFIG_ENERGY_MODEL Quentin Perret
2019-04-17 9:43 ` [PATCH v2 2/3] PM / EM: Expose perf domain struct Quentin Perret
2019-04-17 9:43 ` [PATCH v2 3/3] thermal: cpu_cooling: Migrate to using the EM framework Quentin Perret
2019-04-18 3:53 ` Viresh Kumar
2019-04-18 8:04 ` Quentin Perret [this message]
2019-04-22 8:25 ` Viresh Kumar
2019-04-23 8:07 ` Quentin Perret
2019-04-23 8:35 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418080429.pn4r6lnftlfsf4c4@queper01-lin \
--to=quentin.perret@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=edubezval@gmail.com \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).