On Thu, Apr 18, 2019 at 12:11:16PM -0300, Pablo Greco wrote: > Just like the Bananapi M2 Ultra, the Bananapi M2 Berry has a Realtek > RTL8211E RGMII PHY tied to the GMAC. > The PMIC's DC1SW output provides power for the PHY, while the ALDO2 > output provides I/O voltages on both sides. > > Signed-off-by: Pablo Greco > --- > arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 30 +++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts > index f05cabd..0d79e91 100644 > --- a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts > +++ b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts > @@ -50,6 +50,7 @@ > compatible = "sinovoip,bpi-m2-berry", "allwinner,sun8i-r40"; > > aliases { > + ethernet0 = &gmac; > serial0 = &uart0; > }; > > @@ -92,6 +93,22 @@ > status = "okay"; > }; > > +&gmac { > + pinctrl-names = "default"; > + pinctrl-0 = <&gmac_rgmii_pins>; > + phy-handle = <&phy1>; > + phy-mode = "rgmii"; > + phy-supply = <®_dc1sw>; > + status = "okay"; > +}; > + > +&gmac_mdio { > + phy1: ethernet-phy@1 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <1>; > + }; > +}; > + > &i2c0 { > status = "okay"; > > @@ -123,6 +140,13 @@ > status = "okay"; > }; > > +®_aldo2 { > + regulator-always-on; > + regulator-min-microvolt = <2500000>; > + regulator-max-microvolt = <2500000>; > + regulator-name = "vcc-pa"; And if patches 6 and 7 become the first one, you can drop the always-on here. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com