From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_RHS_DOB, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19948C10F0E for ; Thu, 18 Apr 2019 15:56:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4E6C2148D for ; Thu, 18 Apr 2019 15:56:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389605AbfDRP4R (ORCPT ); Thu, 18 Apr 2019 11:56:17 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:59651 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731317AbfDRP4R (ORCPT ); Thu, 18 Apr 2019 11:56:17 -0400 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (Authenticated sender: maxime.ripard@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 25036200006; Thu, 18 Apr 2019 15:56:13 +0000 (UTC) Date: Thu, 18 Apr 2019 17:56:13 +0200 From: Maxime Ripard To: Pablo Greco Cc: linux-sunxi@googlegroups.com, Rob Herring , Mark Rutland , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 5/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Add Bluetooth device node Message-ID: <20190418155613.shiv7geoqyzfy4kf@flea> References: <1555600282-9405-1-git-send-email-pgreco@centosproject.org> <1555600282-9405-6-git-send-email-pgreco@centosproject.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7gshplb6vboqs5gc" Content-Disposition: inline In-Reply-To: <1555600282-9405-6-git-send-email-pgreco@centosproject.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7gshplb6vboqs5gc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 18, 2019 at 12:11:20PM -0300, Pablo Greco wrote: > Since the bananapi-m2-ultra and the bananapi-m2-berry have the same > WiFi/Bluetooth, add the required nodes to the bananapi-m2-berry. > > Signed-off-by: Pablo Greco > --- > arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 26 +++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts > index 78f4a1a..3d0bb7e 100644 > --- a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts > +++ b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts > @@ -96,6 +96,8 @@ > wifi_pwrseq: wifi_pwrseq { > compatible = "mmc-pwrseq-simple"; > reset-gpios = <&pio 6 10 GPIO_ACTIVE_LOW>; /* PG10 WIFI_EN */ > + clocks = <&ccu CLK_OUTA>; > + clock-names = "ext_clock"; > }; > }; > > @@ -171,6 +173,11 @@ > status = "okay"; > }; > > +&pio { > + pinctrl-names = "default"; > + pinctrl-0 = <&clk_out_a_pin>; > +}; > + I'm not sure you answered my question about why that is needed? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --7gshplb6vboqs5gc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXLieHQAKCRDj7w1vZxhR xRTNAP9Fei7K4bp5nwZo3kXTL8DkwjCBKSZTMd9Bho79Y6924gEA6zrbj/iX7vxl LkrPJIu7XAHKYJlGaBBEg0MFa7tqEg8= =XhPx -----END PGP SIGNATURE----- --7gshplb6vboqs5gc--