From: Peter Xu <peterx@redhat.com>
To: Jerome Glisse <jglisse@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
David Hildenbrand <david@redhat.com>,
Hugh Dickins <hughd@google.com>, Maya Gokhale <gokhale2@llnl.gov>,
Pavel Emelyanov <xemul@virtuozzo.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Martin Cracauer <cracauer@cons.org>, Shaohua Li <shli@fb.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Denis Plotnikov <dplotnikov@virtuozzo.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Marty McFadden <mcfadden8@llnl.gov>, Mel Gorman <mgorman@suse.de>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v3 00/28] userfaultfd: write protection support
Date: Fri, 19 Apr 2019 15:53:50 +0800 [thread overview]
Message-ID: <20190419075350.GH13323@xz-x1> (raw)
In-Reply-To: <20190418210702.GN3288@redhat.com>
On Thu, Apr 18, 2019 at 05:07:02PM -0400, Jerome Glisse wrote:
> On Tue, Apr 09, 2019 at 02:08:39PM +0800, Peter Xu wrote:
> > On Wed, Mar 20, 2019 at 10:06:14AM +0800, Peter Xu wrote:
> > > This series implements initial write protection support for
> > > userfaultfd. Currently both shmem and hugetlbfs are not supported
> > > yet, but only anonymous memory. This is the 3nd version of it.
> > >
> > > The latest code can also be found at:
> > >
> > > https://github.com/xzpeter/linux/tree/uffd-wp-merged
> > >
> > > Note again that the first 5 patches in the series can be seen as
> > > isolated work on page fault mechanism. I would hope that they can be
> > > considered to be reviewed/picked even earlier than the rest of the
> > > series since it's even useful for existing userfaultfd MISSING case
> > > [8].
> >
> > Ping - any further comments for v3? Is there any chance to have this
> > series (or the first 5 patches) for 5.2?
>
> Few issues left, sorry for taking so long to get to review, sometimes
> it goes to the bottom of my stack.
>
> I am guessing this should be merge through Andrew ? Unless Andrea have
> a tree for userfaultfd (i am not following all that closely).
>
> From my point of view it almost all look good. I sent review before
> this email. Maybe we need some review from x86 folks on the x86 arch
> changes for the feature ?
Thank you for your time on reviewing the series (my thanks to Mike
too!). I have no idea on anyone else I should ask for help for
further review comments, but anyway I'd be more than glad to discuss
with any further concerns or do anything to move this series forward.
Because AFAIK mutliple userspace projects are waiting for this series
to settle.
Thanks,
--
Peter Xu
prev parent reply other threads:[~2019-04-19 18:32 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 2:06 [PATCH v3 00/28] userfaultfd: write protection support Peter Xu
2019-03-20 2:06 ` [PATCH v3 01/28] mm: gup: rename "nonblocking" to "locked" where proper Peter Xu
2019-03-20 2:06 ` [PATCH v3 02/28] mm: userfault: return VM_FAULT_RETRY on signals Peter Xu
2019-03-20 2:06 ` [PATCH v3 03/28] userfaultfd: don't retake mmap_sem to emulate NOPAGE Peter Xu
2019-03-20 2:06 ` [PATCH v3 04/28] mm: allow VM_FAULT_RETRY for multiple times Peter Xu
2019-04-18 20:11 ` Jerome Glisse
2019-04-19 6:00 ` Peter Xu
2019-03-20 2:06 ` [PATCH v3 05/28] mm: gup: " Peter Xu
2019-03-20 2:06 ` [PATCH v3 06/28] userfaultfd: wp: add helper for writeprotect check Peter Xu
2019-03-20 2:06 ` [PATCH v3 07/28] userfaultfd: wp: hook userfault handler to write protection fault Peter Xu
2019-04-18 20:03 ` Jerome Glisse
2019-03-20 2:06 ` [PATCH v3 08/28] userfaultfd: wp: add WP pagetable tracking to x86 Peter Xu
2019-03-20 2:06 ` [PATCH v3 09/28] userfaultfd: wp: userfaultfd_pte/huge_pmd_wp() helpers Peter Xu
2019-03-20 2:06 ` [PATCH v3 10/28] userfaultfd: wp: add UFFDIO_COPY_MODE_WP Peter Xu
2019-03-20 2:06 ` [PATCH v3 11/28] mm: merge parameters for change_protection() Peter Xu
2019-03-20 2:06 ` [PATCH v3 12/28] userfaultfd: wp: apply _PAGE_UFFD_WP bit Peter Xu
2019-03-20 2:06 ` [PATCH v3 13/28] mm: export wp_page_copy() Peter Xu
2019-03-20 2:06 ` [PATCH v3 14/28] userfaultfd: wp: handle COW properly for uffd-wp Peter Xu
2019-04-18 20:51 ` Jerome Glisse
2019-04-19 6:26 ` Peter Xu
2019-04-19 15:02 ` Jerome Glisse
2019-04-22 12:20 ` Peter Xu
2019-04-22 14:54 ` Jerome Glisse
2019-04-23 3:00 ` Peter Xu
2019-04-23 15:34 ` Jerome Glisse
2019-04-24 8:38 ` Peter Xu
2019-03-20 2:06 ` [PATCH v3 15/28] userfaultfd: wp: drop _PAGE_UFFD_WP properly when fork Peter Xu
2019-03-20 2:06 ` [PATCH v3 16/28] userfaultfd: wp: add pmd_swp_*uffd_wp() helpers Peter Xu
2019-03-20 2:06 ` [PATCH v3 17/28] userfaultfd: wp: support swap and page migration Peter Xu
2019-04-18 20:59 ` Jerome Glisse
2019-04-19 7:42 ` Peter Xu
2019-04-19 15:08 ` Jerome Glisse
2019-04-22 12:23 ` Peter Xu
2019-03-20 2:06 ` [PATCH v3 18/28] khugepaged: skip collapse if uffd-wp detected Peter Xu
2019-03-20 2:06 ` [PATCH v3 19/28] userfaultfd: introduce helper vma_find_uffd Peter Xu
2019-03-20 2:06 ` [PATCH v3 20/28] userfaultfd: wp: support write protection for userfault vma range Peter Xu
2019-03-20 2:06 ` [PATCH v3 21/28] userfaultfd: wp: add the writeprotect API to userfaultfd ioctl Peter Xu
2019-03-20 2:06 ` [PATCH v3 22/28] userfaultfd: wp: enabled write protection in userfaultfd API Peter Xu
2019-03-22 21:37 ` Mike Rapoport
2019-03-20 2:06 ` [PATCH v3 23/28] userfaultfd: wp: don't wake up when doing write protect Peter Xu
2019-03-20 2:06 ` [PATCH v3 24/28] userfaultfd: wp: UFFDIO_REGISTER_MODE_WP documentation update Peter Xu
2019-03-22 21:46 ` Mike Rapoport
2019-03-20 2:06 ` [PATCH v3 25/28] userfaultfd: wp: fixup swap entries in change_pte_range Peter Xu
2019-04-18 21:01 ` Jerome Glisse
2019-03-20 2:06 ` [PATCH v3 26/28] userfaultfd: wp: declare _UFFDIO_WRITEPROTECT conditionally Peter Xu
2019-03-22 21:43 ` Mike Rapoport
2019-03-20 2:06 ` [PATCH v3 27/28] userfaultfd: selftests: refactor statistics Peter Xu
2019-03-20 2:06 ` [PATCH v3 28/28] userfaultfd: selftests: add write-protect test Peter Xu
2019-04-09 6:08 ` [PATCH v3 00/28] userfaultfd: write protection support Peter Xu
2019-04-18 21:07 ` Jerome Glisse
2019-04-19 7:53 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190419075350.GH13323@xz-x1 \
--to=peterx@redhat.com \
--cc=aarcange@redhat.com \
--cc=cracauer@cons.org \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dplotnikov@virtuozzo.com \
--cc=gokhale2@llnl.gov \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jglisse@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcfadden8@llnl.gov \
--cc=mgorman@suse.de \
--cc=mike.kravetz@oracle.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=shli@fb.com \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).