From: Zhenliang Wei <weizhenliang@huawei.com>
To: <ebiederm@xmission.com>, <oleg@redhat.com>, <colona@arista.com>,
<akpm@linux-foundation.org>, <christian@brauner.io>,
<arnd@arndb.de>, <tglx@linutronix.de>, <deepa.kernel@gmail.com>,
<gregkh@linuxfoundation.org>
Cc: <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
<weizhenliang@huawei.com>
Subject: [PATCH] signal: trace_signal_deliver when signal_group_exit
Date: Sat, 20 Apr 2019 18:41:02 +0800 [thread overview]
Message-ID: <20190420104102.44336-1-weizhenliang@huawei.com> (raw)
In the following commit, removing SIGKILL from each thread signal mask
and executing "goto fatal" directly will skip the call to
"trace_signal_deliver". At this point, the delivery tracking of the SIGKILL
signal will be inaccurate.
commit cf43a757fd4944 ("signal: Restore the stop PTRACE_EVENT_EXIT")
Therefore, we need to add trace_signal_deliver before "goto fatal"
after executing sigdelset.
Signed-off-by: Zhenliang Wei <weizhenliang@huawei.com>
---
kernel/signal.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/signal.c b/kernel/signal.c
index 227ba170298e..439b742e3229 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -2441,6 +2441,8 @@ bool get_signal(struct ksignal *ksig)
if (signal_group_exit(signal)) {
ksig->info.si_signo = signr = SIGKILL;
sigdelset(¤t->pending.signal, SIGKILL);
+ trace_signal_deliver(signr, &ksig->info,
+ &sighand->action[signr - 1]);
recalc_sigpending();
goto fatal;
}
--
2.14.1.windows.1
next reply other threads:[~2019-04-20 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-20 10:41 Zhenliang Wei [this message]
2019-04-20 11:22 ` [PATCH] signal: trace_signal_deliver when signal_group_exit Oleg Nesterov
2019-04-22 2:37 weizhenliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190420104102.44336-1-weizhenliang@huawei.com \
--to=weizhenliang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=christian@brauner.io \
--cc=colona@arista.com \
--cc=deepa.kernel@gmail.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).