From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 820F5C10F11 for ; Mon, 22 Apr 2019 19:59:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 479DA204EC for ; Mon, 22 Apr 2019 19:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555963194; bh=3HlxN/ZjXXOBoSccZmR4KyffGY9Aq2oWKKE5HBayHC0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=B46EB5Dihp5bW0gfBw6P+KcvVIXzl92An30z2Vw+YpoSasEQmZM/dyRv+nV9Lf7oy KWGjB8nMOkjdACzxk7hbWBTWqDiS4u+OTwZRNj8EJGrv5PvVznE4bvPJUz6mqhdghO CAfQXv4d360fWH8uJ5B+WeQrnZFNQGFTkwnF8wS8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731866AbfDVT7w (ORCPT ); Mon, 22 Apr 2019 15:59:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:50388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729484AbfDVTrd (ORCPT ); Mon, 22 Apr 2019 15:47:33 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C791218FD; Mon, 22 Apr 2019 19:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555962453; bh=3HlxN/ZjXXOBoSccZmR4KyffGY9Aq2oWKKE5HBayHC0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UvmJIrOrYTF7439pe1R4OqV383CXweuwZRRo5FjZK8PWfSX4cgRryfWRfu7/EsfI+ ysRa4lHsJnki4NONYlePOFkFESCqUeDVcltrzG41p75HLUDGC90AGzZS0kNqnLqozi Hohr5s/KcbQ6+qoBaNgWmz1ygupYMVYx509ThKqc= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Aditya Pakki , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 03/43] qlcnic: Avoid potential NULL pointer dereference Date: Mon, 22 Apr 2019 15:46:47 -0400 Message-Id: <20190422194727.12495-3-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190422194727.12495-1-sashal@kernel.org> References: <20190422194727.12495-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aditya Pakki [ Upstream commit 5bf7295fe34a5251b1d241b9736af4697b590670 ] netdev_alloc_skb can fail and return a NULL pointer which is dereferenced without a check. The patch avoids such a scenario. Signed-off-by: Aditya Pakki Signed-off-by: David S. Miller Signed-off-by: Sasha Levin (Microsoft) --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c index 7f7deeaf1cf0..da042bc520d4 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c @@ -1047,6 +1047,8 @@ int qlcnic_do_lb_test(struct qlcnic_adapter *adapter, u8 mode) for (i = 0; i < QLCNIC_NUM_ILB_PKT; i++) { skb = netdev_alloc_skb(adapter->netdev, QLCNIC_ILB_PKT_SIZE); + if (!skb) + break; qlcnic_create_loopback_buff(skb->data, adapter->mac_addr); skb_put(skb, QLCNIC_ILB_PKT_SIZE); adapter->ahw->diag_cnt = 0; -- 2.19.1