From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27A17C282CE for ; Mon, 22 Apr 2019 19:52:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEFD7204EC for ; Mon, 22 Apr 2019 19:52:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555962779; bh=QwMVbHVy+nGpgYwdes4aCLWXsLAvgXCdf1ZMxe/eN9A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=E5qfcF85bHk34L9II0gccWYl4At/bQ/8FRJTSSHqQJClggBq2TL/m5u/fdPD9OyCm oQ4YDCwSvwxbv7FRoqSY7JJJbtdT2fztoL3lYG0AoPHgOsNK0uCt1tLPemj0ymWK34 HKJOh0WO7gowLWJi8GIdRgS7t7sjy8vs+KJyaB0A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731367AbfDVTw5 (ORCPT ); Mon, 22 Apr 2019 15:52:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:54042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730519AbfDVTuK (ORCPT ); Mon, 22 Apr 2019 15:50:10 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE8CB2177B; Mon, 22 Apr 2019 19:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555962609; bh=QwMVbHVy+nGpgYwdes4aCLWXsLAvgXCdf1ZMxe/eN9A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K67GdQxXzip4zwCkONH+Zi1LtkPkabgBnMehsKf9NcBBEABkuFhvpieQq/PV0onQl YWe5n7lwI3Mupdj9+AN6CMupu0lPJjOLkbiUy+4B8om8aQNDUk62Zx05WWbDhxEV1k wkXhRPGhNYQ6SeOSryBAVn6pROLwQoLRj6iCr9SI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wen Yang , Douglas Miller , "David S. Miller" , netdev@vger.kernel.org, Sasha Levin Subject: [PATCH AUTOSEL 4.4 13/21] net: ibm: fix possible object reference leak Date: Mon, 22 Apr 2019 15:49:33 -0400 Message-Id: <20190422194941.13433-13-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190422194941.13433-1-sashal@kernel.org> References: <20190422194941.13433-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wen Yang [ Upstream commit be693df3cf9dd113ff1d2c0d8150199efdba37f6 ] The call to ehea_get_eth_dn returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/net/ethernet/ibm/ehea/ehea_main.c:3163:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3154, but without a corresponding object release within this function. Signed-off-by: Wen Yang Cc: Douglas Miller Cc: "David S. Miller" Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: David S. Miller Signed-off-by: Sasha Levin (Microsoft) --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 2a0dc127df3f..1a56de06b014 100644 --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c @@ -3183,6 +3183,7 @@ static ssize_t ehea_probe_port(struct device *dev, if (ehea_add_adapter_mr(adapter)) { pr_err("creating MR failed\n"); + of_node_put(eth_dn); return -EIO; } -- 2.19.1