From: Greg KH <gregkh@linuxfoundation.org>
To: Zhenliang Wei <weizhenliang@huawei.com>
Cc: ebiederm@xmission.com, oleg@redhat.com, colona@arista.com,
akpm@linux-foundation.org, christian@brauner.io, arnd@arndb.de,
tglx@linutronix.de, deepa.kernel@gmail.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3] signal: trace_signal_deliver when signal_group_exit
Date: Mon, 22 Apr 2019 22:41:52 +0200 [thread overview]
Message-ID: <20190422204152.GA5869@kroah.com> (raw)
In-Reply-To: <20190422145950.78056-1-weizhenliang@huawei.com>
On Mon, Apr 22, 2019 at 10:59:50PM +0800, Zhenliang Wei wrote:
> In the fixes commit, removing SIGKILL from each thread signal mask
> and executing "goto fatal" directly will skip the call to
> "trace_signal_deliver". At this point, the delivery tracking of the SIGKILL
> signal will be inaccurate.
>
> Therefore, we need to add trace_signal_deliver before "goto fatal"
> after executing sigdelset.
>
> Note: The action[SIGKILL] must be SIG_DFL, and SEND_SIG_NOINFO matches
> the fact that SIGKILL doesn't have any info.
>
> Acked-by: Christian Brauner <christian@brauner.io>
> Fixes: cf43a757fd4944 ("signal: Restore the stop PTRACE_EVENT_EXIT")
> Signed-off-by: Zhenliang Wei <weizhenliang@huawei.com>
> ---
> kernel/signal.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 227ba170298e..0f69ada376ef 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2441,6 +2441,7 @@ bool get_signal(struct ksignal *ksig)
> if (signal_group_exit(signal)) {
> ksig->info.si_signo = signr = SIGKILL;
> sigdelset(¤t->pending.signal, SIGKILL);
> + trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, SIG_DFL);
> recalc_sigpending();
> goto fatal;
> }
> --
> 2.14.1.windows.1
>
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2019-04-22 20:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 14:59 [PATCH v3] signal: trace_signal_deliver when signal_group_exit Zhenliang Wei
2019-04-22 15:25 ` Oleg Nesterov
2019-04-22 20:41 ` Greg KH [this message]
2019-04-22 23:01 ` kbuild test robot
2019-04-23 1:09 ` kbuild test robot
2019-04-23 13:10 weizhenliang
2019-04-23 13:33 ` Christian Brauner
2019-04-23 13:35 ` Oleg Nesterov
2019-04-23 14:02 weizhenliang
2019-04-23 14:13 weizhenliang
2019-04-23 14:25 weizhenliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190422204152.GA5869@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=christian@brauner.io \
--cc=colona@arista.com \
--cc=deepa.kernel@gmail.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=weizhenliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).