linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools lib traceevent: Change tag string for error
Date: Wed, 24 Apr 2019 20:45:56 +0800	[thread overview]
Message-ID: <20190424124556.GA8948@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20190424124427.GC4339@redhat.com>

On Wed, Apr 24, 2019 at 09:44:27AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Apr 24, 2019 at 08:08:29AM -0400, Steven Rostedt escreveu:
> > On Wed, 24 Apr 2019 09:38:02 +0800
> > Leo Yan <leo.yan@linaro.org> wrote:
> > 
> > > The traceevnt lib is used by perf tool, when execute 'perf test -v 6' it
> > > outputs error log on ARM64 platform:
> > > 
> > >   running test 33 '*:*'trace-cmd: No such file or directory
> > > 
> > >   [...]
> > > 
> > >   trace-cmd: Invalid argument
> > > 
> > > The trace event parsing code originally came from trace-cmd so it keeps
> > > the tag string "trace-cmd" for errors, this easily introduces the
> > > impression that perf tool launches trace-cmd command for trace event
> > > parsing, but in fact the related parsing is accomplished by traceevent
> > > lib.
> > > 
> > > This patch changes the tag string to "libtraceevent" so can avoid
> > > confusion and let users to be more easily to connect the error with
> > > traceevent lib.
> > > 
> > > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> > 
> > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > 
> > Arnaldo,
> > 
> > Can you pull this into your tree.
> 
> Sure, applied.

Thanks, Steven and Arnaldo.

  reply	other threads:[~2019-04-24 12:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24  1:38 [PATCH] tools lib traceevent: Change tag string for error Leo Yan
2019-04-24 12:08 ` Steven Rostedt
2019-04-24 12:44   ` Arnaldo Carvalho de Melo
2019-04-24 12:45     ` Leo Yan [this message]
2019-05-03  5:54 ` [tip:perf/urgent] " tip-bot for Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190424124556.GA8948@leoy-ThinkPad-X240s \
    --to=leo.yan@linaro.org \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).