From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Joe Lawrence <joe.lawrence@redhat.com>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/3] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable()
Date: Wed, 24 Apr 2019 10:50:45 -0500 [thread overview]
Message-ID: <20190424155045.ecwv2ppur3aekrtq@treble> (raw)
In-Reply-To: <20190424085550.29612-3-pmladek@suse.com>
Adding Thomas because this might slightly conflict with some of the
stacktrace.c improvements he's working on.
On Wed, Apr 24, 2019 at 10:55:49AM +0200, Petr Mladek wrote:
> WARN_ONCE() in the generic save_stack_trace_tsk_reliable() is superfluous.
> The only current user klp_check_stack() writes its own warning when
> -ENOSYS is returned.
>
> Signed-off-by: Petr Mladek <pmladek@suse.com>
> ---
> kernel/stacktrace.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c
> index f8edee9c792d..83ac0ac5ffd9 100644
> --- a/kernel/stacktrace.c
> +++ b/kernel/stacktrace.c
> @@ -74,6 +74,5 @@ __weak int
> save_stack_trace_tsk_reliable(struct task_struct *tsk,
> struct stack_trace *trace)
> {
> - WARN_ONCE(1, KERN_INFO "save_stack_tsk_reliable() not implemented yet.\n");
> return -ENOSYS;
> }
> --
> 2.16.4
>
--
Josh
next prev parent reply other threads:[~2019-04-24 15:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 8:55 [PATCH 0/3] livepatch/stacktrace: Clean up of reliable stacktrace errors Petr Mladek
2019-04-24 8:55 ` [PATCH 1/3] livepatch: Convert error about unsupported reliable stacktrace into a warning Petr Mladek
2019-04-24 15:51 ` Josh Poimboeuf
2019-04-24 18:31 ` Miroslav Benes
2019-04-25 3:18 ` Kamalesh Babulal
2019-04-29 14:44 ` Petr Mladek
2019-04-24 8:55 ` [PATCH 2/3] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable() Petr Mladek
2019-04-24 9:07 ` Petr Mladek
2019-04-24 15:50 ` Josh Poimboeuf [this message]
2019-04-24 15:51 ` Josh Poimboeuf
2019-04-24 18:35 ` Miroslav Benes
2019-04-25 3:22 ` Kamalesh Babulal
2019-04-24 8:55 ` [PATCH 3/3] livepatch: Cleanup message handling in klp_try_switch_task() Petr Mladek
2019-04-24 10:41 ` Jiri Kosina
2019-04-24 12:49 ` Petr Mladek
2019-04-24 15:55 ` Josh Poimboeuf
2019-04-24 18:48 ` Miroslav Benes
2019-04-25 3:32 ` Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424155045.ecwv2ppur3aekrtq@treble \
--to=jpoimboe@redhat.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).