From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDC87C10F11 for ; Wed, 24 Apr 2019 17:11:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7DEC421902 for ; Wed, 24 Apr 2019 17:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556125880; bh=p5iA3egXRYekOc5rD7Q/DqQ9TgJI9W1H6ZN5zgW5Ml8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=s5846esYXApa7M4U46IoECNK4hZEuIB9C6uvjPyj1xt13StGHjgIr3XXqyNc9g96X IzKoTCEQbzg52+BBlQiJkdOi6iNCfWkYutVvefYvyZWut63oUk9kYlawDkWAJp4/6T JuVkFhq4lDQQH68UQE+ZmlthM4ocEpgWnUN7qvIY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733229AbfDXRLT (ORCPT ); Wed, 24 Apr 2019 13:11:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:34674 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733183AbfDXRLM (ORCPT ); Wed, 24 Apr 2019 13:11:12 -0400 Received: from localhost (62-193-50-229.as16211.net [62.193.50.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D7702148D; Wed, 24 Apr 2019 17:11:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556125871; bh=p5iA3egXRYekOc5rD7Q/DqQ9TgJI9W1H6ZN5zgW5Ml8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zm5PwPkqcn6yl2m5ixdNL+tA6wQlz8YLGHMXwtjvg5RQNcxJaUbOSFNsbZB79tsMB ytfRXVN/19D5hObqMNQONQojI3vBN0z15ykbTwYR3Zk5IuVFgaOUK0p8gM8SFG88ll E4snMP6QuK/+A+bmKwLs4jmuGFO64+G9NGxBYTRs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Sartain , Mathias Krause , Tony Jones , "Steven Rostedt (VMware)" , Frederic Weisbecker , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 3.18 013/104] tools lib traceevent: Fix buffer overflow in arg_eval Date: Wed, 24 Apr 2019 19:08:30 +0200 Message-Id: <20190424170848.593750010@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190424170839.996641496@linuxfoundation.org> References: <20190424170839.996641496@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 7c5b019e3a638a5a290b0ec020f6ca83d2ec2aaa ] Fix buffer overflow observed when running perf test. The overflow is when trying to evaluate "1ULL << (64 - 1)" which is resulting in -9223372036854775808 which overflows the 20 character buffer. If is possible this bug has been reported before but I still don't see any fix checked in: See: https://www.spinics.net/lists/linux-perf-users/msg07714.html Reported-by: Michael Sartain Reported-by: Mathias Krause Signed-off-by: Tony Jones Acked-by: Steven Rostedt (VMware) Cc: Frederic Weisbecker Fixes: f7d82350e597 ("tools/events: Add files to create libtraceevent.a") Link: http://lkml.kernel.org/r/20190228015532.8941-1-tonyj@suse.de Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/lib/traceevent/event-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c index 0c81ca7d18cd..84374e313e3f 100644 --- a/tools/lib/traceevent/event-parse.c +++ b/tools/lib/traceevent/event-parse.c @@ -2283,7 +2283,7 @@ static int arg_num_eval(struct print_arg *arg, long long *val) static char *arg_eval (struct print_arg *arg) { long long val; - static char buf[20]; + static char buf[24]; switch (arg->type) { case PRINT_ATOM: -- 2.19.1