From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8820EC10F11 for ; Wed, 24 Apr 2019 17:11:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E7D421902 for ; Wed, 24 Apr 2019 17:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556125917; bh=EWe8M8hvLyUBpyhIGhjmksfqK98LSI5ywUbOVWJCwN4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=roHkmUmyN9pqbOgtjWtpB7W5imCUEd3zeWH6egCiSH6Pf+QsMs5KVHrVcBKYOxxh9 YSd8pGNlE4DABS4EX8LI24409soaRfsZBs17s7habCuML9ihEvBVKQak+Dm7LyySUI WNwTXsrv2pkFzLJnTdVtjCmb4JqevgCFomvc11LI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387500AbfDXRL4 (ORCPT ); Wed, 24 Apr 2019 13:11:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:35448 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387466AbfDXRLt (ORCPT ); Wed, 24 Apr 2019 13:11:49 -0400 Received: from localhost (62-193-50-229.as16211.net [62.193.50.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B3498218FE; Wed, 24 Apr 2019 17:11:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556125909; bh=EWe8M8hvLyUBpyhIGhjmksfqK98LSI5ywUbOVWJCwN4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W08Yb8iRaW+qtPM+tY+cgSClT9Q9OyrNTGv1J/PXxU9lN3LwFsOFQwnBe50XaiDye VPc+g6E4MRsmuI1Ktu5r9lG3bt+K14Deb4ArrCedJgscXnVnM8GP3bM8jRBX6a8ZJW fUPfFzZJHNxbLq+ieB6Kx+n+5q9U2hXc0aRxDkf4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Coly Li , Jens Axboe , Sasha Levin Subject: [PATCH 3.18 026/104] bcache: fix input overflow to sequential_cutoff Date: Wed, 24 Apr 2019 19:08:43 +0200 Message-Id: <20190424170855.604664394@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190424170839.996641496@linuxfoundation.org> References: <20190424170839.996641496@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 8c27a3953e92eb0b22dbb03d599f543a05f9574e ] People may set sequential_cutoff of a cached device via sysfs file, but current code does not check input value overflow. E.g. if value 4294967295 (UINT_MAX) is written to file sequential_cutoff, its value is 4GB, but if 4294967296 (UINT_MAX + 1) is written into, its value will be 0. This is an unexpected behavior. This patch replaces d_strtoi_h() by sysfs_strtoul_clamp() to convert input string to unsigned integer value, and limit its range in [0, UINT_MAX]. Then the input overflow can be fixed. Signed-off-by: Coly Li Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/md/bcache/sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c index 87daccbbc61b..463ce6757338 100644 --- a/drivers/md/bcache/sysfs.c +++ b/drivers/md/bcache/sysfs.c @@ -215,7 +215,9 @@ STORE(__cached_dev) d_strtoul(writeback_rate_d_term); d_strtoul_nonzero(writeback_rate_p_term_inverse); - d_strtoi_h(sequential_cutoff); + sysfs_strtoul_clamp(sequential_cutoff, + dc->sequential_cutoff, + 0, UINT_MAX); d_strtoi_h(readahead); if (attr == &sysfs_clear_stats) -- 2.19.1