From: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>,
"airlied@linux.ie" <airlied@linux.ie>,
Brian Starkey <Brian.Starkey@arm.com>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"sean@poorly.run" <sean@poorly.run>, nd <nd@arm.com>,
Ayan Halder <Ayan.Halder@arm.com>,
"Tiannan Zhu (Arm Technology China)" <Tiannan.Zhu@arm.com>,
"Jonathan Chai (Arm Technology China)" <Jonathan.Chai@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Julien Yin (Arm Technology China)" <Julien.Yin@arm.com>,
"Yiqi Kang (Arm Technology China)" <Yiqi.Kang@arm.com>,
"thomas Sun (Arm Technology China)" <thomas.Sun@arm.com>,
"Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>
Subject: Re: [PATCH] drm/komeda: Mark the local functions as static
Date: Thu, 25 Apr 2019 06:17:28 +0000 [thread overview]
Message-ID: <20190425061721.GA20409@james-ThinkStation-P300> (raw)
In-Reply-To: <CACvgo50zWO61bbY7Mwxhp0YSxaPT02aTEfG6pzUZ8bpPkzyo=g@mail.gmail.com>
On Wed, Apr 24, 2019 at 12:06:55PM +0100, Emil Velikov wrote:
> On Wed, 24 Apr 2019 at 06:51, james qian wang (Arm Technology China)
> <james.qian.wang@arm.com> wrote:
> >
> > Fix the kbuild test rebot reported warnings:
> > - symbol was not declared. Should it be static?
> > - missing braces around initializer
> >
> > Depends on:
> > - https://patchwork.freedesktop.org/series/58976/
> >
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Signed-off-by: James (Qian) Wang <james.qian.wang@arm.com>
> > ---
> > .../gpu/drm/arm/display/komeda/d71/d71_component.c | 9 +++++----
> > drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 4 ++--
> > drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 4 +++-
> > drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 2 +-
> > drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c | 2 +-
> > .../drm/arm/display/komeda/komeda_pipeline_state.c | 11 ++++++-----
> > drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 10 ++++++----
> > 7 files changed, 24 insertions(+), 18 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> > index c56cfc2de147..031e5f305a3c 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> > @@ -391,7 +391,7 @@ static void d71_compiz_dump(struct komeda_component *c, struct seq_file *sf)
> > seq_printf(sf, "CU_USER_HIGH:\t\t0x%X\n", v[1]);
> > }
> >
> > -struct komeda_component_funcs d71_compiz_funcs = {
> > +static struct komeda_component_funcs d71_compiz_funcs = {
>
> Side note: Practically any piece of komeda_component_funcs and
> komeda_pipeline_funcs could (and should) be constified.
>
> -Emil
Thank you Emil, I submit a new patch for fixing this problem,
https://patchwork.freedesktop.org/series/59915/
pls help to have a look.
James
prev parent reply other threads:[~2019-04-25 6:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 5:51 [PATCH] drm/komeda: Mark the local functions as static james qian wang (Arm Technology China)
2019-04-24 9:45 ` Liviu Dudau
2019-04-24 11:06 ` Emil Velikov
2019-04-25 6:17 ` james qian wang (Arm Technology China) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425061721.GA20409@james-ThinkStation-P300 \
--to=james.qian.wang@arm.com \
--cc=Ayan.Halder@arm.com \
--cc=Brian.Starkey@arm.com \
--cc=Jonathan.Chai@arm.com \
--cc=Julien.Yin@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Lowry.Li@arm.com \
--cc=Tiannan.Zhu@arm.com \
--cc=Yiqi.Kang@arm.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=nd@arm.com \
--cc=sean@poorly.run \
--cc=thomas.Sun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).