From: Simon Horman <horms@verge.net.au>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: jmorris@namei.org, sashal@kernel.org, ebiederm@xmission.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kexec: quiet down kexec reboot
Date: Thu, 25 Apr 2019 11:10:19 +0200 [thread overview]
Message-ID: <20190425091019.4oqhaxfr6lug5zbo@verge.net.au> (raw)
In-Reply-To: <20190423204154.3085-1-pasha.tatashin@soleen.com>
On Tue, Apr 23, 2019 at 04:41:54PM -0400, Pavel Tatashin wrote:
> Here is a regular kexec command sequence and output:
> =====
> $ kexec --reuse-cmdline -i --load Image
> $ kexec -e
> [ 161.342002] kexec_core: Starting new kernel
>
> Welcome to Buildroot
> buildroot login:
> =====
>
> Even when "quiet" kernel parameter is specified, "kexec_core: Starting
> new kernel" is printed.
>
> This message has KERN_EMERG level, but there is no emergency, it is
> a normal kexec operation, so quiet it down to appropriate KERN_NOTICE.
>
> Machines that have slow console baud rate benefit from less output.
>
> Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com>
Reviewed-by: Simon Horman <horms@verge.net.au>
> ---
> kernel/kexec_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> index d7140447be75..fe13e86984ec 100644
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -1171,7 +1171,7 @@ int kernel_kexec(void)
> * CPU hotplug again; so re-enable it here.
> */
> cpu_hotplug_enable();
> - pr_emerg("Starting new kernel\n");
> + pr_notice("Starting new kernel\n");
> machine_shutdown();
> }
>
> --
> 2.21.0
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
next prev parent reply other threads:[~2019-04-25 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 20:41 [PATCH] kexec: quiet down kexec reboot Pavel Tatashin
2019-04-25 9:10 ` Simon Horman [this message]
2019-04-25 12:13 ` Pavel Tatashin
2019-04-25 9:32 ` Baoquan He
2019-04-25 9:41 ` Baoquan He
2019-04-25 12:12 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425091019.4oqhaxfr6lug5zbo@verge.net.au \
--to=horms@verge.net.au \
--cc=ebiederm@xmission.com \
--cc=jmorris@namei.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).