From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2429CC43218 for ; Thu, 25 Apr 2019 19:25:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5029620717 for ; Thu, 25 Apr 2019 19:25:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556220352; bh=c1dI8Lm5pogCbPehldSp6FfOR3hKKDRZ43Ug9KrLdnc=; h=From:To:Cc:Subject:In-Reply-To:Date:List-ID:From; b=Sla9kZm1SpKjzqzc2AX+EZF+14pHi7acn9hGWNEHJAloaDkE6/v5bUTD0aV+wTqxQ D+1yL2t0p8F40AP7q6Zw59dneDtK8dQ9hpMjJD4W0JGpe5TZHFBikWRcT97AkTxob2 84O9e76vDPfQys/18DHOXxIlzPnW1hn9zucwPngc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730429AbfDYTZp (ORCPT ); Thu, 25 Apr 2019 15:25:45 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:49290 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726379AbfDYTYt (ORCPT ); Thu, 25 Apr 2019 15:24:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=rUCCYlSKF/qclFXhgY+bxsxBF+YN9mSJtdmJVnP9YDE=; b=ZNcO+ZHrtMNJ Tnmp8wa9TfPLT2rrS1ncka0JGRxk/cNzq8/0YJMV3iyxBEauIes9k1FWfI85yOLgjBPhLydsxLybf Fk5S0umSmbQMEKCAu8RGUcxVUM/F65poPjvqGWBZPBVd1fKVpQ2PKsdHA/7Wrpw7HJB4beqvOREop vIdZI=; Received: from 188.29.164.24.threembb.co.uk ([188.29.164.24] helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hJjz8-0004Zs-WE; Thu, 25 Apr 2019 19:24:43 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id F41DD441D3B; Thu, 25 Apr 2019 20:24:41 +0100 (BST) From: Mark Brown To: Linus Walleij Cc: Bartosz Golaszewski , Charles Keepax , Liam Girdwood , linux-kernel@vger.kernel.org, Marek Szyprowski , Mark Brown Subject: Applied "regulator: core: Actually put the gpiod after use" to the regulator tree In-Reply-To: <20190420113430.9856-1-linus.walleij@linaro.org> X-Patchwork-Hint: ignore Message-Id: <20190425192441.F41DD441D3B@finisterre.ee.mobilebroadband> Date: Thu, 25 Apr 2019 20:24:41 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch regulator: core: Actually put the gpiod after use has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.1 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 78927aa40bc82f32de07323ddc1c9de07ac68180 Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Sat, 20 Apr 2019 13:34:30 +0200 Subject: [PATCH] regulator: core: Actually put the gpiod after use I went to great lengths to hand over the management of the GPIO descriptors to the regulator core, and some stray rebased oneliner in the old patch must have been assuming the devices were still doing devres management of it. We handed the management over to the regulator core, so of course the regulator core shall issue gpiod_put() when done. Sorry for the descriptor leak. Fixes: 541d052d7215 ("regulator: core: Only support passing enable GPIO descriptors") Signed-off-by: Linus Walleij Signed-off-by: Mark Brown --- drivers/regulator/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 8573dd0871fd..35a7d020afec 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2256,6 +2256,7 @@ static void regulator_ena_gpio_free(struct regulator_dev *rdev) if (pin->gpiod == rdev->ena_pin->gpiod) { if (pin->request_count <= 1) { pin->request_count = 0; + gpiod_put(pin->gpiod); list_del(&pin->list); kfree(pin); rdev->ena_pin = NULL; -- 2.20.1