From: David Miller <davem@davemloft.net>
To: gustavo@embeddedor.com
Cc: leedom@chelsio.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, keescook@chromium.org
Subject: Re: [PATCH net-next] cxgb4/cxgb4vf_main: Mark expected switch fall-through
Date: Fri, 26 Apr 2019 11:29:39 -0400 (EDT) [thread overview]
Message-ID: <20190426.112939.1227994731110797983.davem@davemloft.net> (raw)
In-Reply-To: <20190424162742.GA10085@embeddedor>
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Wed, 24 Apr 2019 11:27:42 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c: In function ‘fwevtq_handler’:
> drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c:520:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> cpl = (void *)p;
> ~~~~^~~~~~~~~~~
> drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c:524:2: note: here
> case CPL_SGE_EGR_UPDATE: {
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied.
prev parent reply other threads:[~2019-04-26 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 16:27 [PATCH net-next] cxgb4/cxgb4vf_main: Mark expected switch fall-through Gustavo A. R. Silva
2019-04-26 15:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426.112939.1227994731110797983.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=leedom@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).