From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: peter_hong@fintek.com.tw, johan@kernel.org,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V8 2/4] USB: serial: f81232: fix interrupt worker not stop
Date: Fri, 26 Apr 2019 08:26:08 +0200 [thread overview]
Message-ID: <20190426062608.GC12280@localhost> (raw)
In-Reply-To: <1555641933-19336-2-git-send-email-hpeter+linux_kernel@gmail.com>
On Fri, Apr 19, 2019 at 10:45:31AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> The F81232 will use LSR/Interrupt worker to handle LSR error & MSR
> change. This patch will fix the interrupt work should stop in close()
> and suspend().
>
> Cc: Johan Hovold <johan@kernel.org>
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
> ---
> v8:
> 1: no change
>
> v7:
> 1: first introduce to this series patch.
>
> drivers/usb/serial/f81232.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
> index 1f0dd4087d79..25ec47d7f318 100644
> --- a/drivers/usb/serial/f81232.c
> +++ b/drivers/usb/serial/f81232.c
> @@ -576,6 +576,7 @@ static void f81232_close(struct usb_serial_port *port)
> usb_serial_generic_close(port);
> usb_kill_urb(port->interrupt_in_urb);
> flush_work(&port_priv->lsr_work);
> + flush_work(&port_priv->interrupt_work);
> port_priv->is_port_open = false;
>
> mutex_unlock(&port_priv->lock);
> @@ -679,8 +680,10 @@ static int f81232_suspend(struct usb_serial *serial, pm_message_t message)
>
> usb_kill_urb(port->interrupt_in_urb);
>
> - if (port_priv)
> + if (port_priv) {
> flush_work(&port_priv->lsr_work);
> + flush_work(&port_priv->interrupt_work);
> + }
I think this one should go before the lsr_work() patch as it's fixing
current functionality.
Johan
next prev parent reply other threads:[~2019-04-26 6:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 2:45 [PATCH V8 1/4] USB: serial: f81232: clear overrun flag Ji-Ze Hong (Peter Hong)
2019-04-19 2:45 ` [PATCH V8 2/4] USB: serial: f81232: fix interrupt worker not stop Ji-Ze Hong (Peter Hong)
2019-04-26 6:26 ` Johan Hovold [this message]
2019-04-19 2:45 ` [PATCH V8 3/4] USB: serial: f81232: add high baud rate support Ji-Ze Hong (Peter Hong)
2019-04-19 2:45 ` [PATCH V8 4/4] USB: serial: f81232: implement break control Ji-Ze Hong (Peter Hong)
2019-04-26 6:23 ` [PATCH V8 1/4] USB: serial: f81232: clear overrun flag Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426062608.GC12280@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).