From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA02EC43218 for ; Fri, 26 Apr 2019 09:45:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99BD5206BA for ; Fri, 26 Apr 2019 09:45:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556271920; bh=4p1Pi4pZsoEPqt9DBJNIZ0iwd/ToTxdJnjDwN0alzl0=; h=From:To:Cc:Subject:In-Reply-To:Date:List-ID:From; b=htM6ISwVnP4jLJy/wOJr64RrKXn1WTTzUZpo20UtH+rIfzSt5kj/SnDTPlTpsOjIW F4NXjukm/qut47bGHMF1d/tAL1fd2NbOmiVSBFptioLYFofOlUe1p2iBN5PSyzll27 BlmRDfO7fI75CgCSXqXPZWDQtKXxSd6lRmnHd+7Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727389AbfDZJpT (ORCPT ); Fri, 26 Apr 2019 05:45:19 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:54170 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726088AbfDZJpS (ORCPT ); Fri, 26 Apr 2019 05:45:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=q+zwuou8U8DvhcL65NHTR7cDygSOpux/5Y2Z7hQw9JI=; b=CT4VgEwZz+ta 3KX3XP8tirmUTO+fBsDZ6BdQj2FF8q8lMU920s0XuZtF2WSr5/Al8XRWK0QIQbZJfZgjxyvpjbRN0 M4Yug/HGhNA3iayllEEpV6oDa0rjxRsOiNgror5Gvz02FFH0wbDM1DJDd2L5D8e9Wb7lehGbyoDjM WPV0M=; Received: from [37.205.61.202] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hJxPv-0003Qv-Ch; Fri, 26 Apr 2019 09:45:15 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 59F54441D3C; Fri, 26 Apr 2019 10:45:03 +0100 (BST) From: Mark Brown To: Axel Lin Cc: linux-kernel@vger.kernel.org, Mark Brown Subject: Applied "regulator: tps6524x: Remove *rdev[N_REGULATORS] from struct tps6524x" to the regulator tree In-Reply-To: X-Patchwork-Hint: ignore Message-Id: <20190426094503.59F54441D3C@finisterre.ee.mobilebroadband> Date: Fri, 26 Apr 2019 10:45:03 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch regulator: tps6524x: Remove *rdev[N_REGULATORS] from struct tps6524x has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 7a8b0e66df5ad04d0acf31d43b37be46504b9fbc Mon Sep 17 00:00:00 2001 From: Axel Lin Date: Sat, 13 Apr 2019 15:30:02 +0800 Subject: [PATCH] regulator: tps6524x: Remove *rdev[N_REGULATORS] from struct tps6524x Current code is using devm_regulator_register() so we don't need to store *rdev for clean up, use a local variable instead. Signed-off-by: Axel Lin Signed-off-by: Mark Brown --- drivers/regulator/tps6524x-regulator.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/tps6524x-regulator.c b/drivers/regulator/tps6524x-regulator.c index c09223c34dbf..740aeccdfb1f 100644 --- a/drivers/regulator/tps6524x-regulator.c +++ b/drivers/regulator/tps6524x-regulator.c @@ -137,7 +137,6 @@ struct tps6524x { struct spi_device *spi; struct mutex lock; struct regulator_desc desc[N_REGULATORS]; - struct regulator_dev *rdev[N_REGULATORS]; }; static int __read_reg(struct tps6524x *hw, int reg) @@ -584,6 +583,7 @@ static int pmic_probe(struct spi_device *spi) const struct supply_info *info = supply_info; struct regulator_init_data *init_data; struct regulator_config config = { }; + struct regulator_dev *rdev; int i; init_data = dev_get_platdata(dev); @@ -616,10 +616,9 @@ static int pmic_probe(struct spi_device *spi) config.init_data = init_data; config.driver_data = hw; - hw->rdev[i] = devm_regulator_register(dev, &hw->desc[i], - &config); - if (IS_ERR(hw->rdev[i])) - return PTR_ERR(hw->rdev[i]); + rdev = devm_regulator_register(dev, &hw->desc[i], &config); + if (IS_ERR(rdev)) + return PTR_ERR(rdev); } return 0; -- 2.20.1