linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yue Haibing <yuehaibing@huawei.com>
To: <pmladek@suse.com>, <sergey.senozhatsky@gmail.com>,
	<andriy.shevchenko@linux.intel.com>, <geert+renesas@glider.be>,
	<rostedt@goodmis.org>, <me@tobin.cc>
Cc: <linux-kernel@vger.kernel.org>, YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH -next] lib/vsprintf: Make function pointer_string static
Date: Sat, 27 Apr 2019 00:46:30 +0800	[thread overview]
Message-ID: <20190426164630.22104-1-yuehaibing@huawei.com> (raw)

From: YueHaibing <yuehaibing@huawei.com>

Fix sparse warning:

lib/vsprintf.c:673:6: warning:
 symbol 'pointer_string' was not declared. Should it be static?

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 lib/vsprintf.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 1f367f3..7b0a614 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -670,8 +670,9 @@ char *string(char *buf, char *end, const char *s,
 	return string_nocheck(buf, end, s, spec);
 }
 
-char *pointer_string(char *buf, char *end, const void *ptr,
-		     struct printf_spec spec)
+static char *pointer_string(char *buf, char *end,
+			    const void *ptr,
+			    struct printf_spec spec)
 {
 	spec.base = 16;
 	spec.flags |= SMALL;
-- 
2.7.4



             reply	other threads:[~2019-04-26 16:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-26 16:46 Yue Haibing [this message]
2019-04-26 17:02 ` [PATCH -next] lib/vsprintf: Make function pointer_string static Steven Rostedt
2019-04-29 11:08   ` Petr Mladek
2019-04-29 13:13     ` Steven Rostedt
2019-04-29 14:30       ` Petr Mladek
2019-04-29 14:39         ` Steven Rostedt
2019-04-29 16:42           ` Joe Perches
2019-04-30  8:42             ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190426164630.22104-1-yuehaibing@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@tobin.cc \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).