From: Alex Williamson <alex.williamson@redhat.com>
To: Sinan Kaya <Okaya@kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
mr.nuke.me@gmail.com, linux-pci@vger.kernel.org,
austin_bolen@dell.com, alex_gagniuc@dellteam.com,
keith.busch@intel.com, Shyam_Iyer@Dell.com, lukas@wunner.de,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Add link_change error handler and vfio-pci user
Date: Mon, 29 Apr 2019 10:59:26 -0600 [thread overview]
Message-ID: <20190429105926.209d17d3@x1.home> (raw)
In-Reply-To: <76169da9-36cd-6754-41e7-47c8ef668648@kernel.org>
On Mon, 29 Apr 2019 09:45:28 -0700
Sinan Kaya <Okaya@kernel.org> wrote:
> On 4/29/2019 10:51 AM, Alex Williamson wrote:
> > So where do we go from here? I agree that dmesg is not necessarily a
> > great choice for these sorts of events and if they went somewhere else,
> > maybe I wouldn't have the same concerns about them generating user
> > confusion or contributing to DoS vectors from userspace drivers. As it
> > is though, we have known cases where benign events generate confusing
> > logging messages, which seems like a regression. Drivers didn't ask
> > for a link_change handler, but nor did they ask that the link state to
> > their device be monitored so closely. Maybe this not only needs some
> > sort of change to the logging mechanism, but also an opt-in by the
> > driver if they don't expect runtime link changes. Thanks,
>
> Is there anyway to detect autonomous hardware management support and
> not report link state changes in that situation?
>
> I thought there were some capability bits for these.
Not that we can find, this doesn't trigger the separate autonomous
bandwidth notification interrupt. Thanks,
Alex
next prev parent reply other threads:[~2019-04-29 16:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 22:42 [PATCH] PCI: Add link_change error handler and vfio-pci user Alex Williamson
2019-04-24 16:45 ` Alex_Gagniuc
2019-04-24 17:19 ` Alex Williamson
2019-04-24 17:35 ` Alex G
2019-04-24 17:57 ` Bjorn Helgaas
2019-04-29 14:51 ` Alex Williamson
2019-04-29 16:45 ` Sinan Kaya
2019-04-29 16:59 ` Alex Williamson [this message]
2019-04-30 17:59 ` Keith Busch
2019-04-29 17:43 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429105926.209d17d3@x1.home \
--to=alex.williamson@redhat.com \
--cc=Okaya@kernel.org \
--cc=Shyam_Iyer@Dell.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mr.nuke.me@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).