* [PATCH] kernel: remove the unused device_private_entry_fault export
@ 2019-04-29 11:55 Christoph Hellwig
2019-04-29 14:45 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2019-04-29 11:55 UTC (permalink / raw)
To: akpm; +Cc: dan.j.williams, jglisse, linux-kernel
This export has been entirely unused since it was added more than 1 1/2
years ago.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
kernel/memremap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/memremap.c b/kernel/memremap.c
index 4e59d29245f4..1490e63f69a9 100644
--- a/kernel/memremap.c
+++ b/kernel/memremap.c
@@ -45,7 +45,6 @@ vm_fault_t device_private_entry_fault(struct vm_area_struct *vma,
*/
return devmem->page_fault(vma, addr, page, flags, pmdp);
}
-EXPORT_SYMBOL(device_private_entry_fault);
#endif /* CONFIG_DEVICE_PRIVATE */
static void pgmap_array_delete(struct resource *res)
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kernel: remove the unused device_private_entry_fault export
2019-04-29 11:55 [PATCH] kernel: remove the unused device_private_entry_fault export Christoph Hellwig
@ 2019-04-29 14:45 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2019-04-29 14:45 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Andrew Morton, Jérôme Glisse, Linux Kernel Mailing List
On Mon, Apr 29, 2019 at 4:56 AM Christoph Hellwig <hch@lst.de> wrote:
>
> This export has been entirely unused since it was added more than 1 1/2
> years ago.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> kernel/memremap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/memremap.c b/kernel/memremap.c
> index 4e59d29245f4..1490e63f69a9 100644
> --- a/kernel/memremap.c
> +++ b/kernel/memremap.c
> @@ -45,7 +45,6 @@ vm_fault_t device_private_entry_fault(struct vm_area_struct *vma,
> */
> return devmem->page_fault(vma, addr, page, flags, pmdp);
> }
> -EXPORT_SYMBOL(device_private_entry_fault);
> #endif /* CONFIG_DEVICE_PRIVATE */
Looks good to me.
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-29 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-29 11:55 [PATCH] kernel: remove the unused device_private_entry_fault export Christoph Hellwig
2019-04-29 14:45 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).