From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40BD2C43219 for ; Mon, 29 Apr 2019 14:50:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 117DF20656 for ; Mon, 29 Apr 2019 14:50:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Ah5nNChg"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="eqFUYsKY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728471AbfD2Ouk (ORCPT ); Mon, 29 Apr 2019 10:50:40 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42016 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728350AbfD2Ouj (ORCPT ); Mon, 29 Apr 2019 10:50:39 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 3C462605A2; Mon, 29 Apr 2019 14:50:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556549439; bh=Med0BVNCDB0qzfpASZ4nce6f8HqonA2tKuVNkYHuYQI=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Ah5nNChgvOOw6mOmFgT7PL5tXnN5pdBdG8kBIovG6ogqF8qbt5KsONyyvZkLpNIjB iHA5ZelqrKgwdeoAq1WjsWY1uy7C6x7mOROm+Nl2EMGKIIgilQgFUF5X4HfHK5XD86 Pp1cZMfjQaEqBwWVBT0/ZyO1POKTO3k9qaBrZKY0= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6E88060214; Mon, 29 Apr 2019 14:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556549438; bh=Med0BVNCDB0qzfpASZ4nce6f8HqonA2tKuVNkYHuYQI=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=eqFUYsKYQ/rCJUcCjTjobW0O2VTsNvQOhxsfHu/6Vez8QwUFRBnH2SFAdOuS/hTka 078kCQE1N3wui2PpI8xCGaKM64GRqIyWR4Z7C7brfagSNkF0X27Q+RnnMzJET9Fi0g 85S8YUEwaylKD48uLyOKMcmKhJgH1fTa5g5PbpL8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6E88060214 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath6kl: remove redundant check of status != 0 From: Kalle Valo In-Reply-To: <20190404134723.24667-1-colin.king@canonical.com> References: <20190404134723.24667-1-colin.king@canonical.com> To: Colin King Cc: "David S . Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190429145039.3C462605A2@smtp.codeaurora.org> Date: Mon, 29 Apr 2019 14:50:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King wrote: > The check on status not being zero is redundant as previous code > paths that set status to an error value break out of the while > loop and hence status is never non-zero at the check. Remove > this redundant code. > > Addresses-Coverity: ("Logically dead code") > Signed-off-by: Colin Ian King > Reviewed-by: Mukesh Ojha > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. e643da21e19a ath6kl: remove redundant check of status != 0 -- https://patchwork.kernel.org/patch/10885625/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches