From: Christoph Hellwig <hch@infradead.org>
To: Ondrej Zary <linux@zary.sk>
Cc: Rik Faith <faith@cs.unc.edu>,
"David A . Hinds" <dahinds@users.sourceforge.net>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] fdomain: Resurrect driver (core)
Date: Mon, 29 Apr 2019 13:32:37 -0700 [thread overview]
Message-ID: <20190429203237.GA19699@infradead.org> (raw)
In-Reply-To: <20190428200626.28092-2-linux@zary.sk>
> +void fdomain_reset(int base)
Should be marked static.
Otherwise looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-04-29 20:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 20:06 [PATCH 0/4] fdomain: Resurrect driver (modular version) Ondrej Zary
2019-04-28 20:06 ` [PATCH 1/4] fdomain: Resurrect driver (core) Ondrej Zary
2019-04-29 20:32 ` Christoph Hellwig [this message]
2019-04-29 21:15 ` [PATCH 1/4 v2] " Ondrej Zary
2019-04-28 20:06 ` [PATCH 2/4] fdomain: Resurrect driver (PCI support) Ondrej Zary
2019-04-29 20:32 ` Christoph Hellwig
2019-04-28 20:06 ` [PATCH 3/4] fdomain: Resurrect driver (ISA support) Ondrej Zary
2019-04-28 20:06 ` [PATCH 4/4] fdomain: Resurrect driver (PCMCIA support) Ondrej Zary
2019-04-29 21:35 ` [PATCH 0/4] fdomain: Resurrect driver (modular version) Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429203237.GA19699@infradead.org \
--to=hch@infradead.org \
--cc=dahinds@users.sourceforge.net \
--cc=faith@cs.unc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@zary.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).