From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C94AC43219 for ; Tue, 30 Apr 2019 00:12:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39784216FD for ; Tue, 30 Apr 2019 00:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556583161; bh=Qj7jW59gUiSs6fU6LGRDGoOojY+Uru2AVRDri1N6fto=; h=From:To:Cc:Subject:Date:List-ID:From; b=BE67BhLAHbaCdRidXd8CxS+3Js9WM64vtJsEb3qVll7wTfipxGl/h045Z5uas6FA3 HMvHKW1Lx2PQDEwnuRWNB6DFQGNIJLAQOdCfUit1qZG0f1GgLwC+RW12XARLpJPYof LMJY1b11tqVN5L7u06kIz6faY+zvrAD80bniI94o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729453AbfD3AMk (ORCPT ); Mon, 29 Apr 2019 20:12:40 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:40963 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729104AbfD3AMj (ORCPT ); Mon, 29 Apr 2019 20:12:39 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 83A8C21B03; Mon, 29 Apr 2019 20:12:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 29 Apr 2019 20:12:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=h47RDnOLR3ulBCU/R /FMwsbaO8IAEzK5MvftA9Vw9lA=; b=lyvhOQj2gYuwzfZOz8UFTiCzc/3lN1GeX XpsIEv3yI+XV6rF3pMTYse14Hl+CRBBrKvjMBqSTAiGJoPtaru6EaJVwrx6UYCqW dDf9ScH8rRU+YrClWT0nh4XzuYKugya2oYZgQD9z9XFEd7A69r6uJJRLaUIT/td6 XGyj4kwU51Cs854S63LLCPmNEhA0pMCodj0cSPe7Nh6FD2mcEC9ZpCST1teT15R+ yiDhnkw+MbkQfVuQfQBJMVaU5VUIgHTgT5dhUHyIdIZETLxZCx9gpEtaZEPXDo8a LTrhV8sSlgoUhTIpRwWtEogwrWEZXRMNC1tdorUgO91OnYYbiZKrw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrieefgdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomhepfdfvohgsihhnucev rdcujfgrrhguihhnghdfuceothhosghinheskhgvrhhnvghlrdhorhhgqeenucfkphepud dvuddrgeegrddvfedtrddukeeknecurfgrrhgrmhepmhgrihhlfhhrohhmpehtohgsihhn sehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from eros.localdomain (ppp121-44-230-188.bras2.syd2.internode.on.net [121.44.230.188]) by mail.messagingengine.com (Postfix) with ESMTPA id 30783103CD; Mon, 29 Apr 2019 20:12:32 -0400 (EDT) From: "Tobin C. Harding" To: Ingo Molnar , Peter Zijlstra Cc: "Tobin C. Harding" , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: [PATCH] sched/cpufreq: Fix kobject memleak Date: Tue, 30 Apr 2019 10:11:44 +1000 Message-Id: <20190430001144.24890-1-tobin@kernel.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently error return from kobject_init_and_add() is not followed by a call to kobject_put(). This means there is a memory leak. Add call to kobject_put() in error path of kobject_init_and_add(). --- kernel/sched/cpufreq_schedutil.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c index 5c41ea367422..3638d2377e3c 100644 --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -771,6 +771,7 @@ static int sugov_init(struct cpufreq_policy *policy) return 0; fail: + kobject_put(&tunables->attr_set.kobj); policy->governor_data = NULL; sugov_tunables_free(tunables); -- 2.21.0