From: "Tobin C. Harding" <me@tobin.cc>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Tobin C. Harding" <tobin@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] sched/cpufreq: Fix kobject memleak
Date: Tue, 30 Apr 2019 15:15:45 +1000 [thread overview]
Message-ID: <20190430051545.GB30100@eros.localdomain> (raw)
In-Reply-To: <20190430042443.GB73609@gmail.com>
On Tue, Apr 30, 2019 at 06:24:43AM +0200, Ingo Molnar wrote:
>
> * Tobin C. Harding <tobin@kernel.org> wrote:
>
> > Currently error return from kobject_init_and_add() is not followed by a
> > call to kobject_put(). This means there is a memory leak.
> >
> > Add call to kobject_put() in error path of kobject_init_and_add().
> >
> > Signed-off-by: Tobin C. Harding <tobin@kernel.org>
> > ---
> >
> > Resend with SOB tag.
>
> Please ignore my previous mail :-)
Cheers Ingo, caught myself not checkpatching :(
thanks,
Tobin.
prev parent reply other threads:[~2019-04-30 5:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 0:17 [PATCH RESEND] sched/cpufreq: Fix kobject memleak Tobin C. Harding
2019-04-30 4:24 ` Ingo Molnar
2019-04-30 5:15 ` Tobin C. Harding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430051545.GB30100@eros.localdomain \
--to=me@tobin.cc \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tobin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).