linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: mh@mike.franken.de
Cc: lukas@wunner.de, tiwai@suse.de, bhelgaas@google.com,
	ckellner@redhat.com, gregkh@linuxfoundation.org, jslaby@suse.cz,
	linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Furquan Shaikh <furquan@google.com>,
	linux-acpi@vger.kernel.org
Subject: Re: [REGRESSION 5.0.8] Dell thunderbolt dock broken (xhci_hcd and thunderbolt)
Date: Tue, 30 Apr 2019 12:00:21 +0300	[thread overview]
Message-ID: <20190430090021.GF26516@lahna.fi.intel.com> (raw)
In-Reply-To: <EksOpJxc6GB@mike.franken.de>

+Rafael, Furquan and linux-acpi

(The original thread is here https://lore.kernel.org/lkml/s5hy33siofw.wl-tiwai@suse.de/T/#u)

On Tue, Apr 30, 2019 at 10:39:00AM +0200, Michael Hirmke wrote:
> Hi Takashi,
> 
> [...]
> >>> I also have XPS 9370 but not that particular dock. I will check tomorrow
> >>> if I can reproduce it as well.
> >>
> >> There aren't too many changes between 5.0.7 and 5.0.8 that touch
> >> PCI/ACPI. This is just a shot in the dark but could you try to revert:
> >>
> >>   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gi
> >>   t/commit/?h=linux-5.0.y&id=da6a87fb0ad43ae811519d2e0aa325c7f792b13a
> >>
> >> and see if it makes any difference?
> 
> >OK, I'm building a test kernel package with the revert in OBS
> >home:tiwai:bsc1133486 repo.  A new kernel will be
> >kernel-default-5.0.10-*g8edeab8:
> >  http://download.opensuse.org/repositories/home:/tiwai:/bsc1133486/standard/
> 
> >Michael, once when the new kernel is ready, please give it a try.
> 
> as far as I can see, state is back to normal with this kernel.
> No more error messages or crashing modules and all devices seem to work
> as expected.
> Only thing is, that the external devices connected to the Thunderbolt
> dock are coming up a little bit slower than with 5.0.7 - but this is
> nothing, I'd worry about.

Thanks for testing.

Rafael, it seems that commit c8b1917c8987 ("ACPICA: Clear status of GPEs
before enabling them") causes problem with Thunderbolt controllers if
you boot with device (dock) connected.

I think the reason is the same that got fixed in v4.14 with commit
ecc1165b8b74 ("ACPICA: Dispatch active GPEs at init time") which the
above commit essentially undoes if I understand it correctly.

  reply	other threads:[~2019-04-30  9:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29 19:47 [REGRESSION 5.0.8] Dell thunderbolt dock broken (xhci_hcd and thunderbolt) Takashi Iwai
2019-04-29 19:54 ` Mika Westerberg
2019-04-29 20:03   ` Michael Hirmke
2019-04-29 20:13     ` Mika Westerberg
2019-04-29 20:36       ` Mika Westerberg
2019-04-29 22:07         ` Takashi Iwai
2019-04-30  8:39           ` Michael Hirmke
2019-04-30  9:00             ` Mika Westerberg [this message]
2019-04-30  9:37               ` Rafael J. Wysocki
2019-05-02 11:48                 ` Greg Kroah-Hartman
2019-05-03 23:35                   ` Furquan Shaikh
2019-05-06  6:45                     ` Mika Westerberg
2019-05-09 11:52                       ` Furquan Shaikh
2019-04-29 20:09   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430090021.GF26516@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=ckellner@redhat.com \
    --cc=furquan@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mh@mike.franken.de \
    --cc=rafael.j.wysocki@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).