From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>,
Nicolai Stange <nstange@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
the arch/x86 maintainers <x86@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Mimi Zohar <zohar@linux.ibm.com>, Juergen Gross <jgross@suse.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Nayna Jain <nayna@linux.ibm.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Joerg Roedel <jroedel@suse.de>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
live-patching@vger.kernel.org,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [RFC][PATCH v3] ftrace/x86_64: Emulate call function while updating in breakpoint handler
Date: Wed, 1 May 2019 15:00:25 -0400 [thread overview]
Message-ID: <20190501150025.40169f1d@gandalf.local.home> (raw)
In-Reply-To: <20190501185726.GR7905@worktop.programming.kicks-ass.net>
On Wed, 1 May 2019 20:57:26 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> On Wed, May 01, 2019 at 11:01:07AM -0700, Linus Torvalds wrote:
> > This looks sane to me, although I'm surprised that we didn't already
> > have an annotation for the nonstandard stack frame for asm files. That
> > probably would be cleaner in a separate commit, but I guess it doesn't
> > matter.
> >
> > Anyway, I'm willing to consider the entry code version if it looks a
> > _lot_ simpler than this (so I'd like to see them side-by-side), but
> > it's not like this looks all that complicated to me either.
>
> So I posted one earlier today:
>
> https://lkml.kernel.org/r/20190501131117.GW2623@hirez.programming.kicks-ass.net
>
> it's about a 1/3rd the number of lines and has 32bit support. It also
> provides all the bits required to implement static_call().
That's the patch I started with.
>
> That is; I think I'm firmly in favour of the entry variant -- provided
> it actually works of course.
And it works. I ran it through tools/testing/selftests/ftrace/ftracetest
and it passed as good as without that patch.
I haven't ran it through my full test suite. I can do that and see how
it makes out.
-- Steve
prev parent reply other threads:[~2019-05-01 19:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 15:32 [RFC][PATCH v3] ftrace/x86_64: Emulate call function while updating in breakpoint handler Steven Rostedt
2019-05-01 18:01 ` Linus Torvalds
2019-05-01 18:52 ` Steven Rostedt
2019-05-01 18:59 ` Linus Torvalds
2019-05-01 19:17 ` Peter Zijlstra
2019-05-01 19:36 ` Linus Torvalds
2019-05-01 18:57 ` Peter Zijlstra
2019-05-01 19:00 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501150025.40169f1d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=jroedel@suse.de \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=nayna@linux.ibm.com \
--cc=ndesaulniers@google.com \
--cc=nstange@suse.de \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).