From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEF1EC43219 for ; Wed, 1 May 2019 20:25:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3A7420866 for ; Wed, 1 May 2019 20:25:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Xb97gUcH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726191AbfEAUZF (ORCPT ); Wed, 1 May 2019 16:25:05 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:51488 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726077AbfEAUZF (ORCPT ); Wed, 1 May 2019 16:25:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=54Ibxew9eyxQN5lW440IVycH60bacny/xYlF2l1rNhk=; b=Xb97gUcHCZD9RGqGC5MTQXLhmx jhvPLYtR58AA02Kza9tI423Ah8WJC3Yl+R83sv97E3DAlQGPTUx1L+UAH/x+/gNWUEtvE4xseJsqC Q+jbfW8ZDZIOxr2VXqyOFbCutT1yUa1yEXjVbQuUvmaNCQ6XhPD0WTPe2S/meTGMSIrA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hLvmm-0008Fn-SV; Wed, 01 May 2019 22:25:00 +0200 Date: Wed, 1 May 2019 22:25:00 +0200 From: Andrew Lunn To: Rasmus Villemoes Cc: Vivien Didelot , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "David S. Miller" , Florian Fainelli , Rasmus Villemoes Subject: Re: [RFC PATCH 4/5] net: dsa: implement vtu_getnext and vtu_loadpurge for mv88e6250 Message-ID: <20190501202500.GE19809@lunn.ch> References: <20190501193126.19196-1-rasmus.villemoes@prevas.dk> <20190501193126.19196-5-rasmus.villemoes@prevas.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190501193126.19196-5-rasmus.villemoes@prevas.dk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 01, 2019 at 07:32:13PM +0000, Rasmus Villemoes wrote: > These are almost identical to the 6185 variants, but have fewer bits > for the FID. > > Bit 10 of the VTU_OP register (offset 0x05) is the VidPolicy bit, > which one should probably preserve in mv88e6xxx_g1_vtu_op(), instead > of always writing a 0. However, on the 6352 family, that bit is > located at bit 12 in the VTU FID register (offset 0x02), and is always > unconditionally cleared by the mv88e6xxx_g1_vtu_fid_write() > function. > > Since nothing in the existing driver seems to know or care about that > bit, it seems reasonable to not add the boilerplate to preserve it for > the 6250 (which would require adding a chip-specific vtu_op function, > or adding chip-quirks to the existing one). > > Signed-off-by: Rasmus Villemoes Reviewed-by: Andrew Lunn Andrew