From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Thomas Backlund <tmb@mageia.org>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Song Liu <liu.song.a23@gmail.com>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: perf build broken in 5.1-rc7
Date: Wed, 1 May 2019 16:26:34 -0400 [thread overview]
Message-ID: <20190501202634.GE21436@kernel.org> (raw)
In-Reply-To: <f9439dd5-009b-8930-f233-6826c7e7c076@mageia.org>
Em Wed, May 01, 2019 at 11:20:02PM +0300, Thomas Backlund escreveu:
>
> Den 01-05-2019 kl. 20:31, skrev Arnaldo Carvalho de Melo:
> > Em Wed, May 01, 2019 at 05:09:59PM +0300, Thomas Backlund escreveu:
> > > Den 01-05-2019 kl. 16:07, skrev Arnaldo Carvalho de Melo:
> > > > Em Tue, Apr 30, 2019 at 04:31:14PM +0300, Thomas Backlund escreveu:
> > > > Can you check the output for
> > > > /tmp/build/perf/feature/test-disassembler-four-args.make.output in your
> > > > system? And also check what is the prototype for the disassembler()
> > > > routine on mageia7?
> > > I guess this is what fails the test:
> > > cat /tmp/build/perf/feature/test-disassembler-four-args.make.output
> > > /usr/bin/ld: /usr/lib64/libbfd.a(plugin.o): in function `try_load_plugin':
> > > /home/iurt/rpmbuild/BUILD/binutils-2.32/objs/bfd/../../bfd/plugin.c:243:
> > > undefined reference to `dlopen'
> > > /usr/bin/ld:
> > > /home/iurt/rpmbuild/BUILD/binutils-2.32/objs/bfd/../../bfd/plugin.c:271:
> > > undefined reference to `dlsym'
> > > /usr/bin/ld:
> > > /home/iurt/rpmbuild/BUILD/binutils-2.32/objs/bfd/../../bfd/plugin.c:256:
> > > undefined reference to `dlclose'
> > > /usr/bin/ld:
> > > /home/iurt/rpmbuild/BUILD/binutils-2.32/objs/bfd/../../bfd/plugin.c:246:
> > > undefined reference to `dlerror'
> > > as we allow dynamic linking and loading
> > > And we use linker flags:
> > > rpm --eval %ldflags
> > > -Wl,--as-needed -Wl,--no-undefined -Wl,-z,relro -Wl,-O1 -Wl,--build-id
> > > -Wl,--enable-new-dtags
> > Would this help?
> >
> > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> > index fe3f97e342fa..6d65874e16c3 100644
> > --- a/tools/perf/Makefile.config
> > +++ b/tools/perf/Makefile.config
> > @@ -227,7 +227,7 @@ FEATURE_CHECK_LDFLAGS-libpython-version := $(PYTHON_EMBED_LDOPTS)
> > EATURE_CHECK_LDFLAGS-libaio = -lrt
> > -FEATURE_CHECK_LDFLAGS-disassembler-four-args = -lbfd -lopcodes
> > +FEATURE_CHECK_LDFLAGS-disassembler-four-args = -lbfd -lopcodes -ldl
> > CFLAGS += -fno-omit-frame-pointer
> > CFLAGS += -ggdb3
> >
>
> Yeah, that fixes it
>
> and /tmp/build/perf/feature/test-disassembler-four-args.make.output is now empty as wanted.
>
>
> So I guess:
>
> Reported-by: Thomas Backlund <tmb@mageia.org>
>
> Tested-by: Thomas Backlund <tmb@mageia.org>
Great, thanks for testing!
- Arnaldo
>
>
> Thanks!
>
>
> --
>
> Thomas
>
--
- Arnaldo
next prev parent reply other threads:[~2019-05-01 20:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 7:26 perf build broken in 5.1-rc7 Thomas Backlund
2019-04-30 7:53 ` Thomas Backlund
2019-04-30 13:06 ` Song Liu
2019-04-30 13:31 ` Thomas Backlund
2019-05-01 3:37 ` Song Liu
2019-05-01 6:42 ` Thomas Backlund
2019-05-01 13:07 ` Arnaldo Carvalho de Melo
2019-05-01 14:09 ` Thomas Backlund
2019-05-01 15:55 ` Thomas Backlund
2019-05-01 17:31 ` Arnaldo Carvalho de Melo
2019-05-01 20:20 ` Thomas Backlund
2019-05-01 20:26 ` Arnaldo Carvalho de Melo [this message]
2019-05-03 5:57 ` [tip:perf/urgent] tools build: Add -ldl to the disassembler-four-args feature test tip-bot for Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501202634.GE21436@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liu.song.a23@gmail.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tmb@mageia.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).