From: Mike Rapoport <rppt@linux.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mel Gorman <mgorman@techsingularity.net>,
Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mikulas Patocka <mpatocka@redhat.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-parisc@vger.kernel.org, linux-mm@kvack.org,
Vlastimil Babka <vbabka@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org
Subject: Re: DISCONTIGMEM is deprecated
Date: Wed, 1 May 2019 23:46:17 +0300 [thread overview]
Message-ID: <20190501204616.GB6135@rapoport-lnx> (raw)
In-Reply-To: <20190428081107.GA30901@infradead.org>
On Sun, Apr 28, 2019 at 01:11:07AM -0700, Christoph Hellwig wrote:
> On Wed, Apr 24, 2019 at 02:33:53PM +0300, Mike Rapoport wrote:
> > On Tue, Apr 23, 2019 at 12:13:54AM -0700, Christoph Hellwig wrote:
> > > On Sun, Apr 21, 2019 at 10:16:04PM +0100, Mel Gorman wrote:
> > > > 32-bit NUMA systems should be non-existent in practice. The last NUMA
> > > > system I'm aware of that was both NUMA and 32-bit only died somewhere
> > > > between 2004 and 2007. If someone is running a 64-bit capable system in
> > > > 32-bit mode with NUMA, they really are just punishing themselves for fun.
> > >
> > > Can we mark it as BROKEN to see if someone shouts and then remove it
> > > a year or two down the road? Or just kill it off now..
> >
> > How about making SPARSEMEM default for x86-32?
>
> Sounds good.
>
> Another question: I always found the option to even select the memory
> models like a bad tradeoff. Can we really expect a user to make a sane
> choice? I'd rather stick to a relativelty optimal choice based on arch
> and maybe a few other parameters (NUMA or not for example) and stick to
> it, reducing the testing matrix.
I've sent patches that remove ARCH_SELECT_MEMORY_MODEL from arm, s390 and
sparc where it anyway has no effect [1].
That leaves arm64, ia64, parisc, powerpc, sh and i386.
I'd say that for i386 selecting between FLAT and SPARSE based on NUMA
sounds reasonable.
I'm not familiar enough with others to say if such enforcement makes any
sense.
Probably powerpc and sh can enable the preferred memory model in
platform/board part of their Kconfig, just like arm.
[1] https://lore.kernel.org/lkml/1556740577-4140-1-git-send-email-rppt@linux.ibm.com
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2019-05-01 20:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 9:43 [PATCH] mm: Do not boost watermarks to avoid fragmentation for the DISCONTIG memory model Mel Gorman
2019-04-19 14:05 ` DISCONTIGMEM is deprecated Matthew Wilcox
2019-04-19 14:28 ` Mel Gorman
2019-04-19 20:08 ` Helge Deller
2019-05-05 8:53 ` Mike Rapoport
2019-04-21 6:38 ` Mike Rapoport
2019-04-21 13:26 ` Matthew Wilcox
2019-04-21 21:16 ` Mel Gorman
2019-04-23 7:13 ` Christoph Hellwig
2019-04-24 11:33 ` Mike Rapoport
2019-04-24 12:21 ` Mel Gorman
2019-04-28 8:11 ` Christoph Hellwig
2019-05-01 20:46 ` Mike Rapoport [this message]
2019-04-22 17:29 ` Christopher Lameter
2019-04-23 16:49 ` Meelis Roos
2019-04-28 8:13 ` Christoph Hellwig
2019-04-29 16:58 ` Luck, Tony
2019-04-29 20:09 ` Christoph Hellwig
2019-04-30 13:40 ` Christopher Lameter
2019-04-23 6:33 ` [PATCH] mm: Do not boost watermarks to avoid fragmentation for the DISCONTIG memory model Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501204616.GB6135@rapoport-lnx \
--to=rppt@linux.ibm.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mpatocka@redhat.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).