From: Ingo Molnar <mingo@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Oleg Nesterov <oleg@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-sh@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] x86: don't use asm-generic/ptrace.h
Date: Wed, 1 May 2019 23:48:05 +0200 [thread overview]
Message-ID: <20190501214805.GA54736@gmail.com> (raw)
In-Reply-To: <20190501173943.5688-5-hch@lst.de>
* Christoph Hellwig <hch@lst.de> wrote:
> Doing the indirection through macros for the regs accessors just
> makes them harder to read, so implement the helpers directly.
>
> Note that only the helpers actually used are implemented now.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/x86/include/asm/ptrace.h | 29 ++++++++++++++++++++++++-----
> 1 file changed, 24 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/include/asm/ptrace.h b/arch/x86/include/asm/ptrace.h
> index 8a7fc0cca2d1..9b81ef539eb3 100644
> --- a/arch/x86/include/asm/ptrace.h
> +++ b/arch/x86/include/asm/ptrace.h
> @@ -98,7 +98,6 @@ struct cpuinfo_x86;
> struct task_struct;
>
> extern unsigned long profile_pc(struct pt_regs *regs);
> -#define profile_pc profile_pc
>
> extern unsigned long
> convert_ip_to_linear(struct task_struct *child, struct pt_regs *regs);
> @@ -175,11 +174,31 @@ static inline unsigned long kernel_stack_pointer(struct pt_regs *regs)
> }
> #endif
>
> -#define GET_IP(regs) ((regs)->ip)
> -#define GET_FP(regs) ((regs)->bp)
> -#define GET_USP(regs) ((regs)->sp)
> +static inline unsigned long instruction_pointer(struct pt_regs *regs)
> +{
> + return regs->ip;
> +}
> +static inline void instruction_pointer_set(struct pt_regs *regs,
Nit: missing newline between inline functions.
> + unsigned long val)
> +{
> + regs->ip = val;
> +}
> +
> +static inline unsigned long frame_pointer(struct pt_regs *regs)
> +{
> + return regs->bp;
> +}
>
> -#include <asm-generic/ptrace.h>
> +static inline unsigned long user_stack_pointer(struct pt_regs *regs)
> +{
> + return regs->sp;
> +}
> +
> +static inline void user_stack_pointer_set(struct pt_regs *regs,
> + unsigned long val)
> +{
> + regs->sp = val;
> +}
Other than that:
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
next prev parent reply other threads:[~2019-05-01 21:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 17:39 remove asm-generic/ptrace.h Christoph Hellwig
2019-05-01 17:39 ` [PATCH 1/5] arm64: don't use asm-generic/ptrace.h Christoph Hellwig
2019-05-02 13:54 ` Catalin Marinas
2019-05-01 17:39 ` [PATCH 2/5] powerpc: " Christoph Hellwig
2019-05-02 3:30 ` Michael Ellerman
2019-05-01 17:39 ` [PATCH 3/5] sh: " Christoph Hellwig
2019-05-01 17:39 ` [PATCH 4/5] x86: " Christoph Hellwig
2019-05-01 21:48 ` Ingo Molnar [this message]
2019-05-01 17:39 ` [PATCH 5/5] asm-generic: remove ptrace.h Christoph Hellwig
2019-05-03 13:29 ` Arnd Bergmann
2019-05-02 14:01 ` remove asm-generic/ptrace.h Oleg Nesterov
2019-05-20 6:00 remove asm-generic/ptrace.h v2 Christoph Hellwig
2019-05-20 6:00 ` [PATCH 4/5] x86: don't use asm-generic/ptrace.h Christoph Hellwig
2019-05-20 16:02 ` Oleg Nesterov
2019-06-24 5:47 remove asm-generic/ptrace.h v3 Christoph Hellwig
2019-06-24 5:47 ` [PATCH 4/5] x86: don't use asm-generic/ptrace.h Christoph Hellwig
2019-06-24 7:22 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501214805.GA54736@gmail.com \
--to=mingo@kernel.org \
--cc=arnd@arndb.de \
--cc=hch@lst.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oleg@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).