From: Changbin Du <changbin.du@gmail.com>
To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc: Changbin Du <changbin.du@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
x86@kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 20/27] Documentation: x86: convert i386/IO-APIC.txt to reST
Date: Thu, 2 May 2019 13:42:04 +0800 [thread overview]
Message-ID: <20190502054202.x2oli2ceseneyzdo@mail.google.com> (raw)
In-Reply-To: <20190427152449.19df3fcb@coco.lan>
On Sat, Apr 27, 2019 at 03:24:49PM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 26 Apr 2019 23:31:43 +0800
> Changbin Du <changbin.du@gmail.com> escreveu:
>
> > This converts the plain text documentation to reStructuredText format and
> > add it to Sphinx TOC tree. No essential content change.
> >
> > Signed-off-by: Changbin Du <changbin.du@gmail.com>
> > ---
> > .../x86/i386/{IO-APIC.txt => IO-APIC.rst} | 26 ++++++++++++-------
> > Documentation/x86/i386/index.rst | 10 +++++++
> > Documentation/x86/index.rst | 1 +
> > 3 files changed, 27 insertions(+), 10 deletions(-)
> > rename Documentation/x86/i386/{IO-APIC.txt => IO-APIC.rst} (93%)
> > create mode 100644 Documentation/x86/i386/index.rst
> >
> > diff --git a/Documentation/x86/i386/IO-APIC.txt b/Documentation/x86/i386/IO-APIC.rst
> > similarity index 93%
> > rename from Documentation/x86/i386/IO-APIC.txt
> > rename to Documentation/x86/i386/IO-APIC.rst
> > index 15f5baf7e1b6..aec98f742763 100644
> > --- a/Documentation/x86/i386/IO-APIC.txt
> > +++ b/Documentation/x86/i386/IO-APIC.rst
> > @@ -1,3 +1,11 @@
> > +.. SPDX-License-Identifier: GPL-2.0
> > +
> > +=======
> > +IO-APIC
> > +=======
> > +
> > +:Author: Ingo Molnar <mingo@kernel.org>
> > +
> > Most (all) Intel-MP compliant SMP boards have the so-called 'IO-APIC',
> > which is an enhanced interrupt controller. It enables us to route
> > hardware interrupts to multiple CPUs, or to CPU groups. Without an
> > @@ -13,7 +21,7 @@ usually worked around by the kernel. If your MP-compliant SMP board does
> > not boot Linux, then consult the linux-smp mailing list archives first.
> >
> > If your box boots fine with enabled IO-APIC IRQs, then your
> > -/proc/interrupts will look like this one:
> > +/proc/interrupts will look like this one::
> >
> > ---------------------------->
> ...
> <----------------------------
>
> I would remove those lines, as they sounds like a way used by the
> doc author to "escape" a literal block.
>
Removed.
> Either way:
>
> Reviewed-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
>
>
> > hell:~> cat /proc/interrupts
> > @@ -37,14 +45,14 @@ none of those IRQ sources is performance-critical.
> > In the unlikely case that your board does not create a working mp-table,
> > you can use the pirq= boot parameter to 'hand-construct' IRQ entries. This
> > is non-trivial though and cannot be automated. One sample /etc/lilo.conf
> > -entry:
> > +entry::
> >
> > append="pirq=15,11,10"
> >
> > The actual numbers depend on your system, on your PCI cards and on their
> > PCI slot position. Usually PCI slots are 'daisy chained' before they are
> > connected to the PCI chipset IRQ routing facility (the incoming PIRQ1-4
> > -lines):
> > +lines)::
> >
> > ,-. ,-. ,-. ,-. ,-.
> > PIRQ4 ----| |-. ,-| |-. ,-| |-. ,-| |--------| |
> > @@ -56,7 +64,7 @@ lines):
> > PIRQ1 ----| |- `----| |- `----| |- `----| |--------| |
> > `-' `-' `-' `-' `-'
> >
> > -Every PCI card emits a PCI IRQ, which can be INTA, INTB, INTC or INTD:
> > +Every PCI card emits a PCI IRQ, which can be INTA, INTB, INTC or INTD::
> >
> > ,-.
> > INTD--| |
> > @@ -78,19 +86,19 @@ to have non shared interrupts). Slot5 should be used for videocards, they
> > do not use interrupts normally, thus they are not daisy chained either.
> >
> > so if you have your SCSI card (IRQ11) in Slot1, Tulip card (IRQ9) in
> > -Slot2, then you'll have to specify this pirq= line:
> > +Slot2, then you'll have to specify this pirq= line::
> >
> > append="pirq=11,9"
> >
> > the following script tries to figure out such a default pirq= line from
> > -your PCI configuration:
> > +your PCI configuration::
> >
> > echo -n pirq=; echo `scanpci | grep T_L | cut -c56-` | sed 's/ /,/g'
> >
> > note that this script won't work if you have skipped a few slots or if your
> > board does not do default daisy-chaining. (or the IO-APIC has the PIRQ pins
> > connected in some strange way). E.g. if in the above case you have your SCSI
> > -card (IRQ11) in Slot3, and have Slot1 empty:
> > +card (IRQ11) in Slot3, and have Slot1 empty::
> >
> > append="pirq=0,9,11"
> >
> > @@ -105,7 +113,7 @@ won't function properly (e.g. if it's inserted as a module).
> > If you have 2 PCI buses, then you can use up to 8 pirq values, although such
> > boards tend to have a good configuration.
> >
> > -Be prepared that it might happen that you need some strange pirq line:
> > +Be prepared that it might happen that you need some strange pirq line::
> >
> > append="pirq=0,0,0,0,0,0,9,11"
> >
> > @@ -115,5 +123,3 @@ Good luck and mail to linux-smp@vger.kernel.org or
> > linux-kernel@vger.kernel.org if you have any problems that are not covered
> > by this document.
> >
> > --- mingo
> > -
> > diff --git a/Documentation/x86/i386/index.rst b/Documentation/x86/i386/index.rst
> > new file mode 100644
> > index 000000000000..8747cf5bbd49
> > --- /dev/null
> > +++ b/Documentation/x86/i386/index.rst
> > @@ -0,0 +1,10 @@
> > +.. SPDX-License-Identifier: GPL-2.0
> > +
> > +============
> > +i386 Support
> > +============
> > +
> > +.. toctree::
> > + :maxdepth: 2
> > +
> > + IO-APIC
> > diff --git a/Documentation/x86/index.rst b/Documentation/x86/index.rst
> > index 526f7a008b8e..19323c5b89ce 100644
> > --- a/Documentation/x86/index.rst
> > +++ b/Documentation/x86/index.rst
> > @@ -26,3 +26,4 @@ Linux x86 Support
> > microcode
> > resctrl_ui
> > usb-legacy-support
> > + i386/index
>
>
>
> Thanks,
> Mauro
--
Cheers,
Changbin Du
next prev parent reply other threads:[~2019-05-02 5:42 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 15:31 [PATCH 00/27] Include linux x86 docs into Sphinx TOC tree Changbin Du
2019-04-26 15:31 ` [PATCH 01/27] Documentation: add Linux x86 docs to " Changbin Du
2019-04-26 16:16 ` Borislav Petkov
2019-04-27 2:43 ` Changbin Du
2019-04-26 15:31 ` [PATCH 02/27] Documentation: x86: convert boot.txt to reST Changbin Du
2019-04-27 14:31 ` Mauro Carvalho Chehab
2019-05-02 6:59 ` Changbin Du
2019-04-26 15:31 ` [PATCH 03/27] Documentation: x86: convert topology.txt " Changbin Du
2019-04-27 14:41 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 04/27] Documentation: x86: convert exception-tables.txt " Changbin Du
2019-04-27 14:48 ` Mauro Carvalho Chehab
2019-05-02 3:19 ` Changbin Du
2019-04-26 15:31 ` [PATCH 05/27] Documentation: x86: convert kernel-stacks " Changbin Du
2019-04-27 14:50 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 06/27] Documentation: x86: convert entry_64.txt " Changbin Du
2019-04-27 14:52 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 07/27] Documentation: x86: convert earlyprintk.txt " Changbin Du
2019-04-27 17:17 ` Mauro Carvalho Chehab
2019-05-02 3:27 ` Changbin Du
2019-04-26 15:31 ` [PATCH 08/27] Documentation: x86: convert zero-page.txt " Changbin Du
2019-04-27 17:19 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 09/27] Documentation: x86: convert tlb.txt " Changbin Du
2019-04-27 17:21 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 10/27] Documentation: x86: convert mtrr.txt " Changbin Du
2019-04-27 17:32 ` Mauro Carvalho Chehab
2019-04-27 18:10 ` Mauro Carvalho Chehab
2019-05-02 5:03 ` Changbin Du
2019-04-26 15:31 ` [PATCH 11/27] Documentation: x86: convert pat.txt " Changbin Du
2019-04-27 17:51 ` Mauro Carvalho Chehab
2019-05-02 5:25 ` Changbin Du
2019-04-26 15:31 ` [PATCH 12/27] Documentation: x86: convert protection-keys.txt " Changbin Du
2019-04-27 17:53 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 13/27] Documentation: x86: convert intel_mpx.txt " Changbin Du
2019-04-27 17:54 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 14/27] Documentation: x86: convert amd-memory-encryption.txt " Changbin Du
2019-04-27 17:55 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 15/27] Documentation: x86: convert pti.txt " Changbin Du
2019-04-27 17:57 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 16/27] Documentation: x86: convert microcode.txt " Changbin Du
2019-04-27 17:58 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 17/27] Documentation: x86: convert resctrl_ui.txt " Changbin Du
2019-04-27 18:09 ` Mauro Carvalho Chehab
2019-05-02 5:37 ` Changbin Du
2019-04-26 15:31 ` [PATCH 18/27] Documentation: x86: convert orc-unwinder.txt " Changbin Du
2019-04-27 18:16 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 19/27] Documentation: x86: convert usb-legacy-support.txt " Changbin Du
2019-04-27 18:20 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 20/27] Documentation: x86: convert i386/IO-APIC.txt " Changbin Du
2019-04-27 18:24 ` Mauro Carvalho Chehab
2019-05-02 5:42 ` Changbin Du [this message]
2019-04-26 15:31 ` [PATCH 21/27] Documentation: x86: convert x86_64/boot-options.txt " Changbin Du
2019-04-27 18:30 ` Mauro Carvalho Chehab
2019-05-02 5:49 ` Changbin Du
2019-04-26 15:31 ` [PATCH 22/27] Documentation: x86: convert x86_64/uefi.txt " Changbin Du
2019-04-27 18:31 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 23/27] Documentation: x86: convert x86_64/mm.txt " Changbin Du
2019-04-27 18:35 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 24/27] Documentation: x86: convert x86_64/5level-paging.txt " Changbin Du
2019-04-27 18:36 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 25/27] Documentation: x86: convert x86_64/fake-numa-for-cpusets " Changbin Du
2019-04-27 18:38 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 26/27] Documentation: x86: convert x86_64/cpu-hotplug-spec " Changbin Du
2019-04-27 18:40 ` Mauro Carvalho Chehab
2019-04-26 15:31 ` [PATCH 27/27] Documentation: x86: convert x86_64/machinecheck " Changbin Du
2019-04-27 18:42 ` Mauro Carvalho Chehab
2019-04-26 15:39 ` [PATCH 00/27] Include linux x86 docs into Sphinx TOC tree Mauro Carvalho Chehab
2019-04-27 2:47 ` Changbin Du
2019-04-27 9:54 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502054202.x2oli2ceseneyzdo@mail.google.com \
--to=changbin.du@gmail.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).